Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 29, 2015

Also, rename regression_utils.get_environ -> check_environ, and drop return value (which only caller was ignoring).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2015
@tseaver tseaver added testing hygiene api: pubsub Issues related to the Pub/Sub API. labels Apr 29, 2015
@dhermes
Copy link
Contributor

dhermes commented Apr 29, 2015

LGTM. How did you come across this?

@tseaver
Copy link
Contributor Author

tseaver commented Apr 29, 2015

I was trying to find out how / where we were using / setting project, and accidentally typed git grep project_id=, finding many fewer locations than I expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bede80f on tseaver:squelch-project_id into d21bc3f on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Apr 30, 2015
For consistency, replace all use of `project_id` w/ `project`.
@tseaver tseaver merged commit fb59514 into googleapis:master Apr 30, 2015
@tseaver tseaver deleted the squelch-project_id branch April 30, 2015 03:54
parthea pushed a commit that referenced this pull request Sep 18, 2025
* chore(deps): bump jinja2 from 3.1.4 to 3.1.5 in /.kokoro

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.4...3.1.5)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
…cp/templates/python_library/.kokoro (#849)

Source-Link: googleapis/synthtool@b4fe62e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants