Skip to content

fix: mark server_streaming method as async #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mariatta wants to merge 4 commits into from
Closed

fix: mark server_streaming method as async #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25f8207
fix: mark server_streaming method as async
Mariatta Nov 28, 2022
3ad8395
deindent
Mariatta Nov 29, 2022
17ec342
Fix fragment unit test
Mariatta Nov 30, 2022
7f3808e
Merge branch 'main' into fix-server-streaming-async
Mariatta Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class {{ service.async_client_name }}:

{% for method in service.methods.values() %}
{% with method_name = method.safe_name|snake_case + "_unary" if method.operation_service else method.safe_name|snake_case %}
{%+ if not method.server_streaming %}async {% endif %}def {{ method_name }}(self,
async def {{ method_name }}(self,
{% endwith %}
{% if not method.client_streaming %}
request: Optional[Union[{{ method.input.ident }}, dict]] = None,
Expand Down Expand Up @@ -343,7 +343,7 @@ class {{ service.async_client_name }}:

# Send the request.
{%+ if not method.void %}response = {% endif %}
{% if not method.server_streaming %}await {% endif %}rpc(
rpc(
{% if not method.client_streaming %}
request,
{% else %}
Expand Down
1 change: 1 addition & 0 deletions gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ async def test_{{ method_name }}_async(transport: str = 'grpc_asyncio', request_
message = await response.read()
assert isinstance(message, {{ method.output.ident }})
{% else %}
response = await response
assert isinstance(response, {{ method.client_output_async.ident }})
{% for field in method_output.fields.values() | rejectattr('message') %}
{% if not field.oneof or field.proto3_optional %}
Expand Down