Skip to content

Conversation

@Mariatta
Copy link

@Mariatta Mariatta commented Nov 28, 2022

As found in https://github.com/googleapis/python-bigtable/pull/702/files#diff-cefca7c885a9bf43a6cc4769c788d30041fcffc582df926b7240e03beea308ebR529

In google/cloud/bigtable_v2/services/bigtable/async_client.py file, mutate_rows should become a coroutine.
and the call to the rpc should be awaited.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1503 🦕

@Mariatta Mariatta requested review from a team as code owners November 28, 2022 22:39
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 28, 2022
@atulep atulep self-requested a review December 2, 2022 21:11
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change. Please open an issue first to discuss implementation

@parthea parthea closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server streaming methods are not properly marked as async

3 participants