Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Updated check_tfrecords usage in README.md #15

Closed
wants to merge 1 commit into from
Closed

Updated check_tfrecords usage in README.md #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ tfrecorder create-tfrecords \

Using Python interpreter:
```python
import tfrecorder
from tfrecorder import check
Copy link
Contributor

@mbernico mbernico Aug 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jmarrietar!

@cfezequiel do we want to add check into init.py or update line 74 below to include tfrecorder.check.check_tfrecords()?

Copy link
Contributor

@cfezequiel cfezequiel Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @jmarrietar. We appreciate your contribution. I do think it may be better to add the check import to __init__.py for consistency with the other operations (e.g. client, accessor) so that import tfrecord would be sufficient to access them, as @mbernico suggested. But from tfrecorder import check would still be valid.


tfrecorder.check_tfrecords(
check.check_tfrecords(
file_pattern='/path/to/tfrecords/train*.tfrecord.gz',
num_records=5,
output_dir='/tmp/output')
Expand Down