Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Conversation

@jmarrietar
Copy link
Contributor

@jmarrietar jmarrietar commented Aug 12, 2020

Seems that in README.md the usage for check_tfrecords hasn't been updated yet.

Using Python interpreter:
```python
import tfrecorder
from tfrecorder import check
Copy link
Contributor

@mbernico mbernico Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jmarrietar!

@cfezequiel do we want to add check into init.py or update line 74 below to include tfrecorder.check.check_tfrecords()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @jmarrietar. We appreciate your contribution. I do think it may be better to add the check import to __init__.py for consistency with the other operations (e.g. client, accessor) so that import tfrecord would be sufficient to access them, as @mbernico suggested. But from tfrecorder import check would still be valid.

@jmarrietar
Copy link
Contributor Author

One Question @mbernico, Should I have open an issue first for this?. How would be the best way to report problems with the Tool, as I see is in early development. Also to ask questions about it.

Thanks!.

@mbernico
Copy link
Contributor

@jmarrietar Issues would be awesome for both problems and feature requests, but your pull request is much appreciated as well. We will take all the help we can get and would love to see a community built around TFRecorder. I posed some questions to @cfezequiel re style, but your PR is super valid and we appreciate it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants