#37: add tab output format: --out-format=tab #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Jun 2, 2018
| @@ -0,0 +1,61 @@ | |||
| package printers | |||
There was a problem hiding this comment.
should have a package comment, unless it's in another file for this package
pkg/printers/tab.go
Outdated
|
|
||
| func (p *Tab) Print(ctx context.Context, issues <-chan result.Issue) (bool, error) { | ||
| w := tabwriter.NewWriter(StdOut, 0, 0, 2, ' ', 0) | ||
| defer w.Flush() |
There was a problem hiding this comment.
Error return value of w.Flush is not checked
golangci
force-pushed
the
feature/tab-output-format
branch
from
99d0577 to
6a4b94e
Compare
golangci
force-pushed
the
feature/tab-output-format
branch
from
6a4b94e to
f62d607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.