Skip to content

Additional --out-format (tabwriter) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frou opened this issue May 29, 2018 · 2 comments
Closed

Additional --out-format (tabwriter) #37

frou opened this issue May 29, 2018 · 2 comments
Labels
enhancement New feature or improvement

Comments

@frou
Copy link

frou commented May 29, 2018

golangci-lint has the flag:

--out-format string    Format of output: colored-line-number|line-number|json (default "colored-line-number")

It would be nice if there was an additional format that made use of Go's standard library tabwriter, that would output something like:

cmd\modd\main.go:70:15:     errcheck      Error return value of `runner.Reset` is not checked
daemon.go:123:23:           errcheck      Error return value of `d.cmd.Process.Signal` is not checked
modd_test.go:39:17:         errcheck      Error return value of `ioutil.ReadFile` is not checked
notify\notify.go:40:12:     errcheck      Error return value of `cmd.Run` is not checked
notify\notify.go:52:12:     errcheck      Error return value of `cmd.Run` is not checked
proc.go:37:36:              interfacer    fp can be io.Reader

rather than:

cmd\modd\main.go:70:15: Error return value of `runner.Reset` is not checked (errcheck)
daemon.go:123:23: Error return value of `d.cmd.Process.Signal` is not checked (errcheck)
modd_test.go:39:17: Error return value of `ioutil.ReadFile` is not checked (errcheck)
notify\notify.go:40:12: Error return value of `cmd.Run` is not checked (errcheck)
notify\notify.go:52:12: Error return value of `cmd.Run` is not checked (errcheck)
proc.go:37:36: fp can be io.Reader (interfacer)
@golangci golangci added the enhancement New feature or improvement label May 29, 2018
@jirfag
Copy link
Contributor

jirfag commented Jun 2, 2018

hi! thank you for the issue,
try --out-format=tab please, supported in #62

jirfag added a commit that referenced this issue Jun 2, 2018
#37: add tab output format: --out-format=tab
@frou
Copy link
Author

frou commented Jun 3, 2018

It works well. Thank you, I appreciate it!

@jirfag jirfag closed this as completed Jun 3, 2018
frou added a commit to frou/GoFeather that referenced this issue Jun 3, 2018
Assumes golangci-lint's new "tab" output format is being used

golangci/golangci-lint#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants