build(deps): bump github.com/alexkohler/nakedret to 2.0.1 #3760
Conversation
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
added
blocked
|
Hello, the way that we handle this linter is not right, we have to change that. Instead of "duplicating" the code inside golangci-lint I think it's better to a create PR on nakedret to be able to use it as a dependency. |
Handling of naked returns inside conditionals as well as from nested functions has been added upstream, in alexkohler/nakedret#12 and more commits. This should resolve #1317.
This was updated in alexkohler/nakedret#25 and now this PR uses that analyzer directly! |
|
@ldez linter is updated, and should not be blocked any more! 😄 |
ldez
added
enhancement
zalenskivolt
changed the title
ldez
changed the title
| return // want "naked return in func `NakedretIssue` with 33 lines of code" | ||
| } | ||
|
|
||
| fmt.Println("nakedret") |
There was a problem hiding this comment.
@ldez were these fmt.Println() updates intentional?
should it still test the edge case of 31 lines, by removing two // ... lines below?
There was a problem hiding this comment.
Yes the println is intentional, because I wanted to have at least one std import.
Handling of naked returns inside conditionals as well as from nested functions has been added upstream, in alexkohler/nakedret#12 and more commits.
This should resolve #1317.