nakedret doesn't check "return"s in conditionals

[aaron42net]

The nakedret linter embedded in golangci-lint appears to only check for "return" statements at the top level of the function, outside of conditionals. My expectation is that all returns are checked in functions above the specified length, regardless of nesting.

In golangci-lint's test suite, should line 6 of test/testdata/nakedret.go have an "// ERROR" marker? Letting the first "return" pass here seems wrong:

func NakedretIssue() (a int, b string) {
	if a > 0 {
		return
	}

	if b == "" {
		return 0, "0"
	}
[...]
	return // ERROR "naked return in func `NakedretIssue` with 31 lines of code"
}

Thanks!
-- Aaron

[sayboras]

hi, just want to check if the expected behevior mentioned above is happening for upstream repo https://github.com/alexkohler/nakedret ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.