Skip to content

cmd/go/internal/list: use quiet flag to enable json only output #26631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

cmd/go/internal/list: use quiet flag to enable json only output #26631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/cmd/go/internal/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,15 @@ import (
"cmd/go/internal/cache"
"cmd/go/internal/cfg"
"cmd/go/internal/load"
"cmd/go/internal/modfetch"
"cmd/go/internal/modload"
"cmd/go/internal/work"
)

var CmdList = &base.Command{
// Note: -f -json -m are listed explicitly because they are the most common list flags.
// Do not send CLs removing them because they're covered by [list flags].
UsageLine: "list [-f format] [-json] [-m] [list flags] [build flags] [packages]",
UsageLine: "list [-f format] [-json] [-m] [-q] [list flags] [build flags] [packages]",
Short: "list packages or modules",
Long: `
List lists the named packages, one per line.
Expand Down Expand Up @@ -248,6 +249,9 @@ to semantic versioning, earliest to latest. The flag also changes
the default output format to display the module path followed by the
space-separated version list.

The -q flag will suppress prints about module look ups. This makes
it easier for tools to just use the -json output from the CLI.

The arguments to list -m are interpreted as a list of modules, not packages.
The main module is the module containing the current directory.
The active modules are the main module and its dependencies.
Expand Down Expand Up @@ -291,6 +295,7 @@ var (
listU = CmdList.Flag.Bool("u", false, "")
listTest = CmdList.Flag.Bool("test", false, "")
listVersions = CmdList.Flag.Bool("versions", false, "")
listQuiet = CmdList.Flag.Bool("q", false, "")
)

var nl = []byte{'\n'}
Expand Down Expand Up @@ -351,6 +356,9 @@ func runList(cmd *base.Command, args []string) {
}

if *listM {
if *listQuiet {
modfetch.QuietLookup = true
}
// Module mode.
if *listCgo {
base.Fatalf("go list -cgo cannot be used with -m")
Expand Down