Skip to content

cmd/go/internal/list: use quiet flag to enable json only output #26631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cmd/go/internal/list: use quiet flag to enable json only output #26631

wants to merge 1 commit into from

Conversation

marwan-at-work
Copy link
Contributor

Fixes #26628

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 26, 2018
@gopherbot gopherbot force-pushed the master branch 3 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@zegl
Copy link
Contributor

zegl commented Jul 28, 2018

@bradfitz How come this PR has not been imported to Gerrit?

@marwan-at-work
Copy link
Contributor Author

@zegl seems that it's in Gerrit https://go-review.googlesource.com/c/go/+/126235

@sgnn7 sgnn7 mentioned this pull request Jul 31, 2018
Closed
@gopherbot
Copy link
Contributor

Message from Gerrit User 16375:

Patch Set 1: Code-Review-1

Based on the discussion in #26218 (comment) I don't think this change is necessary, but I'll leave Russ/Bryan to confirm/refute that.

Please don’t reply on this GitHub thread. Visit golang.org/cl/126235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28030:

Patch Set 1:

Patch Set 1: Code-Review-1

Based on the discussion in #26218 (comment) I don't think this change is necessary, but I'll leave Russ/Bryan to confirm/refute that.

Ah, I did not know about stdout/stderr. That's great. I do notice the Quite flag in cache is not being used so this PR may still be useful (although it should probably be a global flag and not just in list) But in either case I can get rid of my weird hack now. Thanks Paul!

Please don’t reply on this GitHub thread. Visit golang.org/cl/126235.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/126235 has been abandoned.

@gopherbot gopherbot closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marwan-at-work @zegl @gopherbot @googlebot