This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps: fix unwrapVcsErr to handle nil causes #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
requested review from
ibrasho and
sdboyer
and removed request for
sdboyer
|
Maybe add a test? I'm not sure how useful that would be tbh. |
On second thought, I think that a test for just the nil case is worthwhile. |
sdboyer
approved these changes
Sep 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
In #1121 I didn't anticipate that incoming vcs errors could have nil original errors, and the result is a nil return value: #1128 (comment)
This PR adjusts
unwrapVcsErrto recognize nil original errors, and wrap them differently.Which issue(s) does this PR fix?
Should fix -> #1128, but let's not close until confirmed.