gps with nil pointer dereference

[victormn]

What version of dep are you using (dep version)?

version : devel
build date :
git hash :
go version : go1.9
go compiler : gc
platform : linux/amd64

What dep command did you run?

dep ensure -update

Root project is "bitbucket.org/arquivei/go-dfeadd"
 13 transitively valid internal packages
 28 external packages imported from 13 projects
(0)   ✓ select (root)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x78 pc=0x755c10]

goroutine 1 [running]:
github.com/golang/dep/internal/gps.(*sourceGateway).sourceURL(0xc4200624e0, 0xb129c0, 0xc420016278, 0x0, 0x0, 0x0, 0x0)
	/home/victor/go/src/github.com/golang/dep/internal/gps/source.go:479 +0x100
github.com/golang/dep/internal/gps.(*sourceCoordinator).getSourceGatewayFor(0xc420322540, 0xb129c0, 0xc420016278, 0xc42001d470, 0x23, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/victor/go/src/github.com/golang/dep/internal/gps/source.go:161 +0x975
github.com/golang/dep/internal/gps.(*SourceMgr).SourceExists(0xc4202f41e0, 0xc42001d470, 0x23, 0x0, 0x0, 0xc420028000, 0x0, 0x40)
	/home/victor/go/src/github.com/golang/dep/internal/gps/source_manager.go:467 +0x91
github.com/golang/dep/internal/gps.(*bridge).SourceExists(0xc4201da510, 0xc42001d470, 0x23, 0x0, 0x0, 0xc42012ac38, 0xc42012acd8, 0x54011b)
	/home/victor/go/src/github.com/golang/dep/internal/gps/bridge.go:132 +0x93
github.com/golang/dep/internal/gps.(*solver).createVersionQueue(0xc420144200, 0xc42001d470, 0x23, 0x0, 0x0, 0xc42022cf80, 0x8, 0x8, 0x0, 0x0, ...)
	/home/victor/go/src/github.com/golang/dep/internal/gps/solver.go:767 +0xed
github.com/golang/dep/internal/gps.(*solver).solve(0xc420144200, 0x0, 0x0, 0xc4201da3f0)
	/home/victor/go/src/github.com/golang/dep/internal/gps/solver.go:492 +0x4cf
github.com/golang/dep/internal/gps.(*solver).Solve(0xc420144200, 0x34, 0xb10440, 0xb6a488, 0xc42001e0d8)
	/home/victor/go/src/github.com/golang/dep/internal/gps/solver.go:442 +0xaa
main.(*ensureCommand).runUpdate(0xc4201031e0, 0xc420088fa0, 0xc4200100f0, 0x0, 0x0, 0xc420011440, 0xb15480, 0xc4202f41e0, 0xc42001e0c4, 0x34, ...)
	/home/victor/go/src/github.com/golang/dep/cmd/dep/ensure.go:383 +0x8c1
main.(*ensureCommand).Run(0xc4201031e0, 0xc420088fa0, 0xc4200100f0, 0x0, 0x0, 0x0, 0x0)
	/home/victor/go/src/github.com/golang/dep/cmd/dep/ensure.go:188 +0x3ec
main.(*Config).Run(0xc420062f00, 0xc420062f00)
	/home/victor/go/src/github.com/golang/dep/cmd/dep/main.go:159 +0x7a2
main.main()
	/home/victor/go/src/github.com/golang/dep/cmd/dep/main.go:45 +0x1fc

What did you expect to see?

What did you see instead?

[sdboyer]

hi! thanks for the issue.

hmm, this is a first. could you paste in the output of dep hash-inputs? that should tell me more about what the inputs are here; i suspect this might be a case of the less-loved hg implementation having an issue.

does this happen reliably, or was it a one-time thing?

[victormn]

The outputs of dep hash-inputs:

-CONSTRAINTS-
bitbucket.org/arquivei/go-dfeparser
svc-^1.1.3
github.com/aws/aws-sdk-go
svc-^1.10.36
github.com/garyburd/redigo
svc-^1.1.0
github.com/go-kit/kit
b-master
github.com/gorilla/mux
b-master
github.com/oklog/ulid
svc-^0.3.0
github.com/pkg/errors
b-master
github.com/prometheus/client_golang
svc-^0.8.0
github.com/spf13/pflag
svc-^1.0.0
github.com/spf13/viper
svc-^1.0.0
github.com/stretchr/testify
svc-^1.1.4
gopkg.in/olivere/elastic.v5
svc-^5.0.45
gopkg.in/yaml.v2
b-v2
-IMPORTS/REQS-
bitbucket.org/arquivei/go-dfeparser/nfe
bitbucket.org/arquivei/go-dfeparser/nfeevent
bitbucket.org/arquivei/go-dfeparser/parser
bitbucket.org/arquivei/go-dfeparser/parsing
bitbucket.org/arquivei/go-dfeparser/rescce
bitbucket.org/arquivei/go-dfeparser/resevento
bitbucket.org/arquivei/go-dfeparser/resnfe
bitbucket.org/arquivei/go-dfeparser/retinutnfe
github.com/aws/aws-sdk-go/aws
github.com/aws/aws-sdk-go/aws/session
github.com/aws/aws-sdk-go/service/s3
github.com/aws/aws-sdk-go/service/sqs
github.com/garyburd/redigo/redis
github.com/go-kit/kit/endpoint
github.com/go-kit/kit/log
github.com/go-kit/kit/metrics
github.com/go-kit/kit/metrics/prometheus
github.com/go-kit/kit/transport/http
github.com/gorilla/mux
github.com/oklog/ulid
github.com/pkg/errors
github.com/prometheus/client_golang/prometheus
github.com/prometheus/client_golang/prometheus/promhttp
github.com/spf13/pflag
github.com/spf13/viper
github.com/stretchr/testify/assert
gopkg.in/olivere/elastic.v5
gopkg.in/yaml.v2
-IGNORES-
-OVERRIDES-
-ANALYZER-
dep
1

I already try to remove the entire dep project of $GOPATH/src, $GOPATH/pkg and $GOPATH/bin and remove Gopkg.lock and Gopkg.toml and install dep again using go get -u github.com/golang/dep/cmd/dep. But, when I try to use dep init I receive the "nil pointer deference" error.

So, I cant use dep anymore :(

[ibrasho]

@jmank88 I believe this could be caused by #1121

Somehow, a vcs.LocalError or vcs.RemoteError is created with e.e = nil. (Masterminds/vcs does this in detectVcsFromRemote)

This makes cause == nil inunwrapVcsErr and therefore it returns nil (since errors.Warp returns nil if the passed err is a nil):

dep/internal/gps/source_errors.go

Lines 15 to 26 in 062d2d0

	func unwrapVcsErr(err error) error {
	switch t := err.(type) {
	case *vcs.LocalError:
	cause, out, msg := t.Original(), t.Out(), t.Error()
	return errors.Wrap(errors.Wrap(cause, out), msg)
	case *vcs.RemoteError:
	cause, out, msg := t.Original(), t.Out(), t.Error()
	return errors.Wrap(errors.Wrap(cause, out), msg)
	default:
	return err
	}
	}

[ibrasho]

I'm still trying to figure out if we do something like that in dep somewhere.

[ibrasho]

@victormn Sorry you had to go through this annoying bug.

My best solution for you is to use the 0.3.0 release until this is fixed.

[sdboyer]

this should be fixed now, eh?

@victormn would you mind retesting your case with the latest from master?

[victormn]

@sdboyer works fine! thank you!

[sdboyer]

great, thanks for checking!