Merge pull request #1142 from jmank88/vcs_err_fix

gps: fix unwrapVcsErr to handle nil causes

Author: sdboyer

internal/gps/source_errors.go

@@ -13,14 +13,23 @@ import (
 // preserving the actual vcs command output and error, in addition to the message.
 // All other types pass through unchanged.
 func unwrapVcsErr(err error) error {
+	var cause error
+	var out, msg string
+
 	switch t := err.(type) {
 	case *vcs.LocalError:
-		cause, out, msg := t.Original(), t.Out(), t.Error()
-		return errors.Wrap(errors.Wrap(cause, out), msg)
+		cause, out, msg = t.Original(), t.Out(), t.Error()
 	case *vcs.RemoteError:
-		cause, out, msg := t.Original(), t.Out(), t.Error()
-		return errors.Wrap(errors.Wrap(cause, out), msg)
+		cause, out, msg = t.Original(), t.Out(), t.Error()
+
 	default:
 		return err
 	}
+
+	if cause == nil {
+		cause = errors.New(out)
+	} else {
+		cause = errors.Wrap(cause, out)
+	}
+	return errors.Wrap(cause, msg)
 }

internal/gps/source_errors_test.go

@@ -0,0 +1,30 @@
+// Copyright 2017 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package gps
+
+import (
+	"testing"
+
+	"github.com/Masterminds/vcs"
+)
+
+func TestUnwrapVcsErrNonNil(t *testing.T) {
+	for _, err := range []error{
+		vcs.NewRemoteError("msg", nil, "out"),
+		vcs.NewRemoteError("msg", nil, ""),
+		vcs.NewRemoteError("", nil, "out"),
+		vcs.NewRemoteError("", nil, ""),
+		vcs.NewLocalError("msg", nil, "out"),
+		vcs.NewLocalError("msg", nil, ""),
+		vcs.NewLocalError("", nil, "out"),
+		vcs.NewLocalError("", nil, ""),
+		&vcs.RemoteError{},
+		&vcs.LocalError{},
+	} {
+		if unwrapVcsErr(err) == nil {
+			t.Errorf("unexpected nil error unwrapping: %#v", err)
+		}
+	}
+}