Skip to content

removed username from users.update_profile_success #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Cyber1000
Copy link

@Cyber1000 Cyber1000 commented Jun 2, 2019

There is no username in english (or other languages)

So in german following can be read: "Der Account „%s“ wurde aktualisiert." (literally with the %s)
Since gitea/routers/admin/users.go doesn't add a username for users.update_profile_success and no other language seems to add a %s in translation for this string I removed it.

(see also my bugreport in #4482 (comment), which addresses more or less 2 "bugs"/inconsistencies)

Der is no username in english (or other languages)
@zeripath
Copy link
Contributor

zeripath commented Jun 2, 2019

Hi!

Our translations are handled on crowdin.

https://crowdin.com/translate/gitea/all/enus-de

Please change this there.

@zeripath zeripath closed this Jun 2, 2019
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 2, 2019
@Cyber1000
Copy link
Author

Thanks for the info, should definitely have read the contribution page before, thought it was only a small fix.
There is already a (now) 8 times upvoted fix (https://crowdin.com/translate/gitea/all/enus-de#q=users.update_profile_success) for the last 10 months, is there a special moment (release?) when this gets approved? It seems approved but the approval is downvoted 7 times, so will anyone notice this?

@codecov-io
Copy link

Codecov Report

Merging #7101 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7101      +/-   ##
==========================================
+ Coverage   41.54%   41.54%   +<.01%     
==========================================
  Files         446      446              
  Lines       60825    60825              
==========================================
+ Hits        25267    25272       +5     
+ Misses      32273    32269       -4     
+ Partials     3285     3284       -1
Impacted Files Coverage Δ
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eba27c...b7981b7. Read the comment docs.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants