Can't change CanImportLocal in User Administration

[Cyber1000]

• Gitea version (or commit ref): fe78154
• Operating system: ubuntu (within docker)
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • [ x] No --> setting is within administration of users
  • Not relevant
• Log gist:

Description

If I edit a user in administration view I can change the CanImportLocal flag, but after saving the flag vanishes ...
The message "Der Account „%s“ wurde aktualisiert." is a bug too, the message comes with %s, instead of the real user name.

Screenshots

[techknowlogick]

IMPORT_LOCAL_PATHS is likely set to false in app.ini (or not set at all which then defaults to false). Please set to true, and try again. More information here: https://docs.gitea.io/en-us/config-cheat-sheet/

[Cyber1000]

IMPORT_LOCAL_PATHS wasn't set. It seems that if the user is a administrator it always automatically gets the default of IMPORT_LOCAL_PATHS.

Now if IMPORT_LOCAL_PATHS=true and I deselect CanImportLocal on a administrative user, it gets selected again automatically when saving. On a normal user I can switch between true and false now. Is this intended behavior?

[lafriks]

Yes that is intended behaviour

[Cyber1000]

Sorry to answer so late, but it's still a little bit strange to me that I check checkboxes, save the site, it says "Account was updated" and afterwards I find that a checkbox has magically rechanged it's flag. A deactivated checkbox or an error-message on saving would be more conclusive for the user.

Also the "Der Account „%s“ wurde aktualisiert." with the %s within doesn't sound to be intended. Seems like the accountname wasn't but in the string properly.

Thanks!

[jxsl13]

Still persists: The message "Der Account „%s“ wurde aktualisiert." is a bug too, the message comes with %s, instead of the real user name.

Seems to be this line, where no username is being added to the string:

gitea/routers/admin/users.go

Line 229 in 801843b

ctx.Flash.Success(ctx.Tr("admin.users.update_profile_success"))

[Cyber1000]

Ok thanks, perhaps I'll have a look at it, when I'm having more time. At least it is a minor bug ...

[kolaente]

@Cyber1000 @jxsl13 I've approved the correct translation on crowdin, it should land in Gitea with the next sync of locales.