Skip to content

Migrate to go modules #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Migrate to go modules #5069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6c1e08
remove gorilla
Oct 11, 2018
f66b25d
remove vendor and ignore
Oct 11, 2018
04f4e36
remove vendor and ignore
Oct 11, 2018
eb6034a
switch to go modules
Oct 11, 2018
9123893
remove dep from Makefile and drone
Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 2 additions & 3 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ pipeline:
event: [ push, tag, pull_request ]

build-without-gcc:
image: golang:1.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this pegged at 1.9 as it is currently the oldest version of go that is supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but the others can remain at 1.11 as we just need to ensure that 1.9 builds, but we will distribute the versions of gitea that are built with a more recent version)

image: golang:1.11
pull: true
commands:
- go build -o gitea_no_gcc # test if build succeeds without the sqlite tag
Expand All @@ -77,7 +77,6 @@ pipeline:
- make swagger-check
- make swagger-validate
- make misspell-check
- make test-vendor
- make build
when:
event: [ push, tag, pull_request ]
Expand Down Expand Up @@ -119,7 +118,7 @@ pipeline:

# Commented until db locking have been resolved!
# test-sqlite:
# image: golang:1.10
# image: golang:1.11
# pull: true
# group: test
# environment:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
vendor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we shouldn't remove the vendor dir.
If a dependency or its host goes down, we can't build Gitea anymore.


# Compiled Object files, Static and Dynamic libs (Shared Objects)
*.o
*.a
Expand Down
Loading