Migrate to go modules #5069

coolaj86 · 2018-10-11T02:13:28Z

remove a few unused modules (bolt, gorilla)
go mod init and go mod tidy (adds go.mod and go.sum)
remove Gopkg.*
update drone file? (doesn't look like there was much to do)

jonasfranz · 2018-10-11T10:07:15Z

.gitignore

@@ -1,3 +1,5 @@
+vendor


IMHO we shouldn't remove the vendor dir.
If a dependency or its host goes down, we can't build Gitea anymore.

jonasfranz · 2018-10-11T10:08:57Z

Please update the makefile in order to make sure that our CI tasks are going to work.

jonasfranz · 2018-10-11T10:11:11Z

Makefile

@@ -172,23 +172,6 @@ coverage:
 unit-test-coverage:
 	for PKG in $(PACKAGES); do $(GO) test -tags=sqlite -cover -coverprofile $$GOPATH/src/$$PKG/coverage.out $$PKG || exit 1; done;

-.PHONY: vendor


Don't remove the vendor and test-vendor tasks.

jonasfranz · 2018-10-11T10:11:32Z

cmd/web.go

@@ -21,7 +21,6 @@ import (
 	"code.gitea.io/gitea/routers/routes"

 	"github.com/Unknwon/com"
-	context2 "github.com/gorilla/context"


Aren't these changes from https://github.com/go-gitea/gitea/pull/5068/files#diff-da541ef36e39344f2e12bddd91d363e2 ?

lunny · 2018-10-11T13:38:33Z

Since Gitea depends on so many Go libraries. I would like to keep vendor to use go mod vendor.

appleboy · 2018-10-15T09:38:45Z

@coolaj86 Add build test in Drone

  build-with-go-module:
    image: golang:1.11
    pull: true
    environment:
      - TAGS="bindata sqlite"
      - GO111MODULE=on
    commands:
      - make clean
      - make generate
      - make build
    when:
      event: [ push, tag, pull_request ]

xor-gate · 2018-10-16T09:17:08Z

As @lunny suggests indeed it is good to cache also in the vendor folder. Because when somebody decides to pull the plug out of a dependency you are screwed.

techknowlogick · 2018-11-02T20:16:02Z

.drone.yml

@@ -56,7 +56,7 @@ pipeline:
      event: [ push, tag, pull_request ]

  build-without-gcc:
-    image: golang:1.9


Can you keep this pegged at 1.9 as it is currently the oldest version of go that is supported.

(but the others can remain at 1.11 as we just need to ensure that 1.9 builds, but we will distribute the versions of gitea that are built with a more recent version)

stale · 2019-01-04T19:51:26Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

techknowlogick · 2019-01-16T15:19:37Z

Closing due to #5743

@earl-warren

…go-gitea#6525) ### Screenshot #### Before See go-gitea#5069. #### After ![image](/attachments/d57c2ff8-d29e-41b8-9280-c884ac43f12e) ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). - Manual testing: see https://codeberg.org/forgejo/forgejo/pulls/6525#issuecomment-2578814. Thanks @earl-warren. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6525 Reviewed-by: Otto <[email protected]> Co-authored-by: Robert Wolff <[email protected]> Co-committed-by: Robert Wolff <[email protected]>

@earl-warren

…go-gitea#6525) ### Screenshot #### Before See go-gitea#5069. #### After ![image](/attachments/d57c2ff8-d29e-41b8-9280-c884ac43f12e) ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). - Manual testing: see https://codeberg.org/forgejo/forgejo/pulls/6525#issuecomment-2578814. Thanks @earl-warren. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6525 Reviewed-by: Otto <[email protected]> Co-authored-by: Robert Wolff <[email protected]> Co-committed-by: Robert Wolff <[email protected]> (cherry picked from commit c0a2108)

@earl-warren

go-gitea#5069 (go-gitea#6739) **Backport:** https://codeberg.org/forgejo/forgejo/pulls/6525 ### Screenshot #### Before See go-gitea#5069. #### After ![image](/attachments/d57c2ff8-d29e-41b8-9280-c884ac43f12e) ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). - Manual testing: see https://codeberg.org/forgejo/forgejo/pulls/6525#issuecomment-2578814. Thanks @earl-warren. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Co-authored-by: Robert Wolff <[email protected]> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6739 Reviewed-by: Robert Wolff <[email protected]> Co-authored-by: forgejo-backport-action <[email protected]> Co-committed-by: forgejo-backport-action <[email protected]>

AJ ONeal added 5 commits October 11, 2018 01:49

remove gorilla

c6c1e08

remove vendor and ignore

f66b25d

remove vendor and ignore

04f4e36

switch to go modules

eb6034a

remove dep from Makefile and drone

9123893

lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Oct 11, 2018

jonasfranz suggested changes Oct 11, 2018

View reviewed changes

bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 11, 2018

jonasfranz suggested changes Oct 11, 2018

View reviewed changes

adelowo mentioned this pull request Oct 15, 2018

feat: support go module for 1.11 #5087

Closed

techknowlogick reviewed Nov 2, 2018

View reviewed changes

stale bot added the issue/stale label Jan 4, 2019

typeless mentioned this pull request Jan 16, 2019

Use Go1.11 module #5743

Merged

techknowlogick closed this Jan 16, 2019

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to go modules #5069

Migrate to go modules #5069

coolaj86 commented Oct 11, 2018

jonasfranz Oct 11, 2018

jonasfranz commented Oct 11, 2018

jonasfranz Oct 11, 2018

jonasfranz Oct 11, 2018

lunny commented Oct 11, 2018

appleboy commented Oct 15, 2018

xor-gate commented Oct 16, 2018

techknowlogick Nov 2, 2018

techknowlogick Nov 2, 2018

stale bot commented Jan 4, 2019

techknowlogick commented Jan 16, 2019

Migrate to go modules #5069

Migrate to go modules #5069

Conversation

coolaj86 commented Oct 11, 2018

jonasfranz Oct 11, 2018

Choose a reason for hiding this comment

jonasfranz commented Oct 11, 2018

jonasfranz Oct 11, 2018

Choose a reason for hiding this comment

jonasfranz Oct 11, 2018

Choose a reason for hiding this comment

lunny commented Oct 11, 2018

appleboy commented Oct 15, 2018

xor-gate commented Oct 16, 2018

techknowlogick Nov 2, 2018

Choose a reason for hiding this comment

techknowlogick Nov 2, 2018

Choose a reason for hiding this comment

stale bot commented Jan 4, 2019

techknowlogick commented Jan 16, 2019