Skip to content

Fix object storage path handling #27024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2023
Merged

Fix object storage path handling #27024

merged 3 commits into from
Sep 13, 2023

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Sep 11, 2023 •
edited
Loading

Object storage path rules:

  • No single / or ., use empty string for root path
  • Need to use trailing / for a list prefix to distinguish a "dir/"

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 11, 2023
@wxiaoguang wxiaoguang mentioned this pull request Sep 11, 2023
Closed
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Sep 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 12, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) September 13, 2023 00:48
@wxiaoguang wxiaoguang merged commit 8ecdc93 into go-gitea:main Sep 13, 2023
@wxiaoguang wxiaoguang deleted the fix-obj-store-path branch September 13, 2023 01:20
@GiteaBot
Copy link
Collaborator

GiteaBot commented Sep 13, 2023

I was unable to create a backport for 1.20. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 27024
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Sep 13, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8251797 
* giteaofficial/main:
  fix media description render for orgmode (go-gitea#26895)
  Show OpenID Connect and OAuth on signup page (go-gitea#20242)
  Update status and code index after changing the default branch (go-gitea#27018)
  add sparse url in cargo package guide (go-gitea#26937)
  Add missing 404 response to Swagger (go-gitea#27038)
  Fix object storage path handling (go-gitea#27024)
  [skip ci] Updated translations via Crowdin
  bump rootful to 16gb
  setup go in the nightly release pipeline
  Speed up nightly builds (go-gitea#27045)
  Improve repo/user/org search  (go-gitea#27030)
  Use Actuated.dev runner for nightly builds
  update snap package (go-gitea#27021)
  resolve issue with sort icons on admin/users and admin/runners (go-gitea#24360)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @GiteaBot @lunny @silverwind