MinIO > 2021 interprets a / prefix differently

[earl-warren]

$ minio --version
minio version RELEASE.2023-08-23T10-07-06Z (commit-id=af564b8ba07a7805a578b5f6f2b3827490f74ccd)
$ make CI=true GOTESTFLAGS='-v -count=1' GO_TEST_PACKAGES=code.gitea.io/gitea/modules/storage FLAGS= 'test#TestMinioStorageIterator'
Running go test with -tags 'sqlite sqlite_unlock_notify'...
=== RUN   TestMinioStorageIterator
2023/08/31 14:09:28 ...les/storage/minio.go:81:NewMinioStorage() [I] Creating Minio storage at 127.0.0.1:9000:gitea with base path
    storage_test.go:49:
        	Error Trace:	/home/earl-warren/software/forgejo/modules/storage/storage_test.go:49
        	            				/home/earl-warren/software/forgejo/modules/storage/minio_test.go:18
        	Error:      	"[a/1.txt b/1.txt b/2.txt b/3.txt b/x 4.txt ab/1.txt]" should have 0 item(s), but has 6
        	Test:       	TestMinioStorageIterator
--- FAIL: TestMinioStorageIterator (0.30s)
FAIL
FAIL	code.gitea.io/gitea/modules/storage	0.306s
FAIL
make: *** [Makefile:470: test#TestMinioStorageIterator] Error 1

[puni9869]

Can you add a test case around it, if applicable.

[silverwind]

Does this mean we require a certain minimum version of minio or is it backwards-compatible?

[earl-warren]

The existing tests fail when used with a recent MinIO server: this part of the code is covered.

[silverwind]

I see we are testing with bitnami/minio:2021.3.17, so I guess keep it at that version.

gitea/.github/workflows/pull-db-tests.yml

Line 34 in d5703d4

image: bitnami/minio:2021.3.17

[wxiaoguang]

The logic is still not right. For example, basePath may not have the trailing slash.

[earl-warren]

The logic is still not right. For example, basePath may not have the trailing slash.

Do you mean the logic of this fix is not right? Or that the logic of the minio implementation is not right?

[wxiaoguang]

I guess "the logic of this fix is not right".

In most Object Storages, prefix "dir" matchs "dir-1" and "dir/sub". If it needs to only match "dir/sub", it needs to use prefix "dir/" to list.

[wxiaoguang]

I guess the right fix is like this: Fix object storage path handling #27024