Skip to content

Enable markdownlint no-inline-html #23581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 19, 2023

With a few exceptions to accomodate current usage. Rule docs.

@silverwind silverwind added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 19, 2023
@silverwind silverwind added this to the 1.20.0 milestone Mar 19, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 19, 2023
@silverwind
Copy link
Member Author

silverwind commented Mar 19, 2023

Note that the rule is a bit too harsh in some cases, that's why the exception list is so long. For example to middle-align something, one can do:

<p align="center">
  I'm <b>bold</b>
</p>

In such a case, <b> usage is unavoidable and okay, but it would trigger the linter. So I'm unsure whether we should really enable it as it will give false-positives for all cases where one needs to use HTML attributes.

@silverwind
Copy link
Member Author

I think I'll decide against this. It could be enabled of there is a smarter rule that detects HTML attribute usage, but as it is, the rule is just too crude to cover our use cases.

@silverwind silverwind closed this Mar 19, 2023
@lunny lunny removed this from the 1.20.0 milestone Mar 20, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@silverwind silverwind deleted the no-inline-html branch May 24, 2023 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants