Skip to content

update documentation #23571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update documentation #23571

wants to merge 1 commit into from

Conversation

weshaan
Copy link

@weshaan weshaan commented Mar 19, 2023

Hey, I made some changes to the introduction text to improve fluency and made slight changes to the table design to make it easier to navigate through.

hope you like it!

Hey, I made some changes to the introduction text to improve fluency and made slight changes to the table design to make it easier to navigate through.

hope you like it!
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <b> instead of **?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2023
@yardenshoham yardenshoham added this to the 1.20.0 milestone Mar 19, 2023
@yardenshoham yardenshoham added the type/docs This PR mainly updates/creates documentation label Mar 19, 2023
@weshaan
Copy link
Author

weshaan commented Mar 19, 2023

<b> is a tag and defines the area of effect better that ** thus reducing syntax error chances, I visited the website and the complete list was a bit overwhelming to navigate through for the first time thats why I decided to make headings stand out different to improve readability.

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 19, 2023

** is as strong as <b>.
**word**, <b>word</b>
word, word
We should keep the document in markdown and prevent mixing HTML in.

@silverwind
Copy link
Member

silverwind commented Mar 19, 2023

Maybe we can enforce this via markdownlint, but I guess some exceptions may be necessary.

@silverwind
Copy link
Member

#23581 for the lint change.

@techknowlogick
Copy link
Member

IIRC b is deprecated, and strong should be used for emphasis. That being said I'm unsure about these changes, and perhaps instead of a list we should list functionality in a different way.

@silverwind
Copy link
Member

silverwind commented Mar 19, 2023

I've decided against this lint rule. It's to forbiding when one needs to use HTML to set HTML attributes like center. Still I think this PR needs to be refactored to not use HTML as there is no reason for <b> usage here.

blog post to read about the justification for a fork.

## Purpose

The goal of this project is to provide the easiest, fastest, and most painless way of setting
up a self-hosted Git service.

With Go, this can be done platform-independently across
**all platforms** which Go supports, including Linux, macOS, and Windows,
This is possible with Go, it is platform-independent and supports **all platforms**, including Linux, macOS, and Windows,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from the previous statement. Gitea should work on all platforms that Go supports, but Go doesn't support "all" platforms.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Go for example does not support Solaris 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Go for example does not support Solaris 😉

It should support Solaris on amd64 arch.
https://go.dev/doc/install/source#environment

Copy link
Member

@silverwind silverwind Mar 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean Solaris on SPARC 😆

@@ -11,22 +11,21 @@ draft: false
# What is Gitea?

Gitea is a painless self-hosted Git service. It is similar to GitHub, Bitbucket, and GitLab.
Gitea is a fork of [Gogs](http://gogs.io). See the [Gitea Announcement](https://blog.gitea.io/2016/12/welcome-to-gitea/)
Gitea is a fork of repository named [Gogs](http://gogs.io). Kindly check out the [Gitea Announcement](https://blog.gitea.io/2016/12/welcome-to-gitea/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's also true that the Gitea repo is a fork of the Gogs repo, the previous statement makes more sense imo, that the Gitea project is a fork of the Gogs project, or "Gitea is a fork of Gogs".

I do like the change to the next sentence, though. 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohkk....thank you for considering 😀

@techknowlogick
Copy link
Member

Thanks for your PR. I'm going to close it due to the comments above. If you'd like to contribute again, please hop into chat and we'd be happy to be able to help out :)

@GiteaBot GiteaBot removed this from the 1.20.0 milestone Apr 28, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants