Skip to content

Add milestone labels #20620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

Add milestone labels #20620

wants to merge 28 commits into from

Conversation

bl00mber
Copy link

@bl00mber bl00mber commented Aug 2, 2022 •
edited
Loading

close #17244

gitea-milestone-labels2

@Gusted Gusted added this to the 1.18.0 milestone Aug 2, 2022
@Gusted Gusted added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 2, 2022
@bl00mber bl00mber force-pushed the milestone-labels branch 7 times, most recently from d77b650 to 31bd3d4 Compare August 3, 2022 00:36
@bl00mber
Copy link
Author

Can you merge @lafriks @silverwind @6543 @techknowlogick @lunny

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 17, 2022
lunny
lunny reviewed Sep 19, 2022
View reviewed changes
lunny
lunny reviewed Sep 19, 2022
View reviewed changes
lunny
lunny reviewed Sep 19, 2022
View reviewed changes
lunny
lunny reviewed Sep 19, 2022
View reviewed changes
@lunny
Copy link
Member

lunny commented Sep 19, 2022

Is it necessary to display milestone's lables in issue view interface? It may made some confusion.

@6543
Copy link
Member

6543 commented Oct 16, 2022

please resolve conflicts

@bl00mber
Copy link
Author

@6543 I will update today

@silverwind
Copy link
Member

silverwind commented May 14, 2023 •
edited
Loading

Could we display labels on the milestone detail page.

I agree but we shouldn't bloat the scope of this PR too much. It's been waiting too long already. Let's get it into a mergable state and refine later.

@lunny
Copy link
Member

lunny commented May 14, 2023

Could we display labels on the milestone detail page.

I agree but we shouldn't bloat the scope of this PR too much. It's been waiting too long already. Let's get it into a mergable state and refine later.

I don't think so. Like issue labels will be displayed in issue list and issue detail page.
Currently milestone labels just are displayed in milestone list. They should also be displayed in milestone detail page.

bl00mber added 2 commits May 18, 2023 00:18
@bl00mber
Update
f76485e
@bl00mber
Update
d93d63c 
* labelExclusiveScopes taken out to a new function
* display labels on milestone detail page
@bl00mber
Copy link
Author

bl00mber commented May 17, 2023 •
edited
Loading

  • labelExclusiveScopes taken out to a new function
  • display labels on milestone detail page

I will update it only one more time, if there are any additional issues with this PR let me know or I am closing it next time.

silverwind added 2 commits May 21, 2023 22:40
@silverwind
update migration number
c71bbd8
@silverwind
Merge branch 'main' into milestone-labels
e336a1e 
* main: (90 commits)
  Refactor rename user and rename organization (go-gitea#24052)
  Use `CommentList` instead of `[]*Comment` (go-gitea#24828)
  Fix topics deleted via API not being deleted in org page (go-gitea#24825)
  Return `404` in the API if the requested webhooks were not found (go-gitea#24823)
  Decouple the different contexts from each other (go-gitea#24786)
  [skip ci] Updated translations via Crowdin
  Add RTL rendering support to Markdown (go-gitea#24816)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#24815)
  Fix duplicate tooltip hiding (go-gitea#24814)
  Mute repo names in dashboard repo list (go-gitea#24811)
  Rework label colors (go-gitea#24790)
  Fix max width and margin of comment box on conversation page (go-gitea#24809)
  Allow all URL schemes in Markdown links by default (go-gitea#24805)
  Some refactors for issues stats (go-gitea#24793)
  Implement actions artifacts (go-gitea#22738)
  Fix Actions being enabled accidentally (go-gitea#24802)
  Change `add_on` in `keys_ssh.tmpl` (go-gitea#24803)
  replace `drone exec` to `act_runner exec` in test README.md (go-gitea#24791)
  Fix OAuth loading state (go-gitea#24788)
  ...
@silverwind
Copy link
Member

Bumped the migration number.

@silverwind
Copy link
Member

Tweaked labels in milestone list to look similar to issue list. The list has more problems, but not related to this PR.

Screenshot 2023-05-21 at 22 57 41

silverwind
silverwind approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ui wise, can't speak for backend changes.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2023
@delvh delvh removed this from the 1.20.0 milestone Jun 5, 2023
denyskon
denyskon reviewed Aug 1, 2023
View reviewed changes
@denyskon
Copy link
Member

denyskon commented Aug 1, 2023

@bl00mber Would be nice if we could merge this feature for 1.21. Could you update your branch and address the open review comments?

@denyskon denyskon added this to the 1.21.0 milestone Aug 1, 2023
@bl00mber
Copy link
Author

@denyskon can you merge?

@denyskon
Copy link
Member

Thanks for the update, I'll review the PR soon

@denyskon
Copy link
Member

I'm sorry, I won't be able to review this large feature before the feature freeze. Unless any other maintainer is able to do so, I'll try to review this for 1.22.

@denyskon denyskon removed this from the 1.21.0 milestone Aug 25, 2023
@denyskon denyskon mentioned this pull request Sep 22, 2023
Closed
yp05327
yp05327 reviewed Feb 22, 2024
View reviewed changes
models/issues/milestone_label.go
Comment on lines +85 to +88
m.Labels = nil
if err = m.LoadLabels(ctx); err != nil {
return err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reasons that we need to clear it and load it from DB instead of adding new labels to m.Labels directly? 🤔

@bl00mber bl00mber closed this Jun 4, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

@yp05327 yp05327 yp05327 left review comments

@6543 6543 6543 left review comments

@denyskon denyskon denyskon left review comments

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Milestone Labels