Skip to content

[Feature Request] Milestone Labels #17244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chriseaton opened this issue Oct 7, 2021 · 11 comments
Open

[Feature Request] Milestone Labels #17244

chriseaton opened this issue Oct 7, 2021 · 11 comments
Assignees
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@chriseaton
Copy link

chriseaton commented Oct 7, 2021

Feature Description

I think it would be super helpful for milestones (and the associated APIs) to support labels. They help quite a bit organizing issues, and on large projects it would be nice to be able to categorize the milestones as well.

Right now in our projects we have to resort to using special keywords in the titles which isn't super-efficient or clear like you see with the labels in issues.

Screenshots

1. Labels could appear below the description in the milestone listing.

Screenshot

2. Leverage the same type of dropdown when creating/editing, just show labels in a horizontal stack.
Screenshot2
)

3. Bonus ask: Would probably also be good to see (likely not edit) the milestone labels on any assigned issue.

Screenshot3
.

@chriseaton chriseaton changed the title Milestone Labels [Feature Request] Milestone Labels Oct 7, 2021
@chriseaton
Copy link
Author

APIs that would need to be created to support milestone labels (if following the same convention as issues):

  • GET ​/repos​/{owner}​/{repo}​/milestones​/{id}​/labels Get an milestones's labels
  • PUT ​/repos​/{owner}​/{repo}​/milestones​/{id}​/labels -Replace an issue's labels
  • POST ​/repos​/{owner}​/{repo}​/milestones​/{id}​/labels Add a label to an issue
  • DELETE ​/repos​/{owner}​/{repo}​/milestones​/{id}​/labels Remove all labels from an issue
  • DELETE ​/repos​/{owner}​/{repo}​/milestones​/{id}​/labels​/{id} Remove a label from an issue

An {id} would be given for the milestone as it doesn't have an index like issues. If you wanted use an index you would also have to update the following to provide them:

  • GET ​/repos​/{owner}​/{repo}​/milestones Get all of a repository's opened milestones

@a1012112796 a1012112796 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 7, 2021
@chriseaton
Copy link
Author

My employer would love this feature and has posted a bounty on it if you are interested.

@techknowlogick
Copy link
Member

@chriseaton whoa, that's huge!! I will get started on this PR right away. Thank you for funding open source development <3

@TKDev7
Copy link

TKDev7 commented Dec 29, 2021

@chriseaton Can I work on this?

@chriseaton
Copy link
Author

@chriseaton Can I work on this?

it's open-source, anyone can!

@lunny lunny added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Dec 30, 2021
@eduardbeutel
Copy link

Hi, I am interested in implementing this feature and would like to clarify some finer points with @chriseaton and the gitea developers @lunny:

  1. New entity MilestoneLabel or mixed-use Label ?

My question is if we want A: to implement a new/second MilestoneLabel entity to hold the labels for milestones or B: reuse the existing Label entity to hold both issue and milestone labels. Solution A would have the consequence of having to develop a new user interface admin "area" for the new MilestoneLabel.

  1. Label.Type ?

If B is the preferred solution then do we want to add a new property Label.Type = Issue|Milestone to the Label entity for differentiation? If we don't, when applying labels to a new milestone (as seen in screenshot 2) the dropdown list will also contain the labels used for issues.

Best regards,
Eduard

@techknowlogick
Copy link
Member

Same labels for both milestones and issues, you can see my linked PR above for how I was able to achieve that

@bryanpedini
Copy link

how I was able to achieve that

Is this FR still considered and WIP?
Thanks!

@eduardbeutel
Copy link

@bryanpedini Hi, I'm not part of the project team here but regarding WIP I wasn't able to dedicate the time to implement the feature, so feel free to have a go at it.

@bryanpedini
Copy link

bryanpedini commented Jul 25, 2022

@eduardbeutel I quoted @techknowlogick's message since they referred to their linked PR, not yours 😅

PS: I'm by no means a Go expert, only a couple of lines of code put here and there, so I can't really talk about implementing stuff in a project big as Gitea, tho as one can grasp by my previous question, I'm very much interested in this feature :)

@maxbol
Copy link

maxbol commented Jul 29, 2022

I'd gladly have a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants