@@ -50,9 +50,9 @@ func GetLabelsByMilestoneID(milestoneID int64) ([]*Label, error) {
50
50
51
51
// newMilestoneLabel this function creates a new label it does not check if the label is valid for the milestone
52
52
// YOU MUST CHECK THIS BEFORE THIS FUNCTION
53
- func newMilestoneLabel (ctx context.Context , milestone * Milestone , label * Label , doer * user_model.User ) (err error ) {
53
+ func newMilestoneLabel (ctx context.Context , m * Milestone , label * Label , doer * user_model.User ) (err error ) {
54
54
if err = db .Insert (ctx , & MilestoneLabel {
55
- MilestoneID : milestone .ID ,
55
+ MilestoneID : m .ID ,
56
56
LabelID : label .ID ,
57
57
}); err != nil {
58
58
return err
@@ -62,8 +62,8 @@ func newMilestoneLabel(ctx context.Context, milestone *Milestone, label *Label,
62
62
}
63
63
64
64
// NewMilestoneLabel creates a new milestone-label relation.
65
- func NewMilestoneLabel (milestone * Milestone , label * Label , doer * user_model.User ) (err error ) {
66
- if HasMilestoneLabel (milestone .ID , label .ID ) {
65
+ func NewMilestoneLabel (m * Milestone , label * Label , doer * user_model.User ) (err error ) {
66
+ if HasMilestoneLabel (m .ID , label .ID ) {
67
67
return nil
68
68
}
69
69
@@ -76,32 +76,32 @@ func NewMilestoneLabel(milestone *Milestone, label *Label, doer *user_model.User
76
76
sess := db .GetEngine (ctx )
77
77
78
78
// Do NOT add invalid labels
79
- if milestone .RepoID != label .RepoID && milestone .Repo .OwnerID != label .OrgID {
79
+ if m .RepoID != label .RepoID && m .Repo .OwnerID != label .OrgID {
80
80
return nil
81
81
}
82
82
83
- if err = newMilestoneLabel (ctx , milestone , label , doer ); err != nil {
83
+ if err = newMilestoneLabel (ctx , m , label , doer ); err != nil {
84
84
return err
85
85
}
86
86
87
- milestone .Labels = nil
88
- if err = milestone .loadLabels (sess ); err != nil {
87
+ m .Labels = nil
88
+ if err = m .loadLabels (sess ); err != nil {
89
89
return err
90
90
}
91
91
92
92
return committer .Commit ()
93
93
}
94
94
95
95
// newMilestoneLabels add labels to an milestone. It will check if the labels are valid for the milestone
96
- func newMilestoneLabels (ctx context.Context , e db.Engine , milestone * Milestone , labels []* Label , doer * user_model.User ) (err error ) {
96
+ func newMilestoneLabels (ctx context.Context , e db.Engine , m * Milestone , labels []* Label , doer * user_model.User ) (err error ) {
97
97
for _ , label := range labels {
98
98
// Don't add already present labels and invalid labels
99
- if hasMilestoneLabel (e , milestone .ID , label .ID ) ||
100
- (label .RepoID != milestone .RepoID && label .OrgID != milestone .Repo .OwnerID ) {
99
+ if hasMilestoneLabel (e , m .ID , label .ID ) ||
100
+ (label .RepoID != m .RepoID && label .OrgID != m .Repo .OwnerID ) {
101
101
continue
102
102
}
103
103
104
- if err = newMilestoneLabel (ctx , milestone , label , doer ); err != nil {
104
+ if err = newMilestoneLabel (ctx , m , label , doer ); err != nil {
105
105
return fmt .Errorf ("newMilestoneLabel: %v" , err )
106
106
}
107
107
}
@@ -110,29 +110,29 @@ func newMilestoneLabels(ctx context.Context, e db.Engine, milestone *Milestone,
110
110
}
111
111
112
112
// NewMilestoneLabels creates a list of milestone-label relations.
113
- func NewMilestoneLabels (milestone * Milestone , labels []* Label , doer * user_model.User ) (err error ) {
113
+ func NewMilestoneLabels (m * Milestone , labels []* Label , doer * user_model.User ) (err error ) {
114
114
ctx , committer , err := db .TxContext ()
115
115
if err != nil {
116
116
return err
117
117
}
118
118
defer committer .Close ()
119
119
120
- if err = newMilestoneLabels (ctx , db .GetEngine (ctx ), milestone , labels , doer ); err != nil {
120
+ if err = newMilestoneLabels (ctx , db .GetEngine (ctx ), m , labels , doer ); err != nil {
121
121
return err
122
122
}
123
123
124
- milestone .Labels = nil
125
- if err = milestone .loadLabels (db .GetEngine (ctx )); err != nil {
124
+ m .Labels = nil
125
+ if err = m .loadLabels (db .GetEngine (ctx )); err != nil {
126
126
return err
127
127
}
128
128
129
129
return committer .Commit ()
130
130
}
131
131
132
- func deleteMilestoneLabel (ctx context.Context , milestone * Milestone , label * Label , doer * user_model.User ) (err error ) {
132
+ func deleteMilestoneLabel (ctx context.Context , m * Milestone , label * Label , doer * user_model.User ) (err error ) {
133
133
// if count, err := db.DeleteByBean(ctx, &MilestoneLabel{
134
134
if count , err := db .DeleteByBean (ctx , & MilestoneLabel {
135
- MilestoneID : milestone .ID ,
135
+ MilestoneID : m .ID ,
136
136
LabelID : label .ID ,
137
137
}); err != nil {
138
138
return err
@@ -143,68 +143,68 @@ func deleteMilestoneLabel(ctx context.Context, milestone *Milestone, label *Labe
143
143
}
144
144
145
145
// DeleteMilestoneLabel deletes milestone-label relation.
146
- func DeleteMilestoneLabel (milestone * Milestone , label * Label , doer * user_model.User ) (err error ) {
146
+ func DeleteMilestoneLabel (m * Milestone , label * Label , doer * user_model.User ) (err error ) {
147
147
ctx , committer , err := db .TxContext ()
148
148
if err != nil {
149
149
return err
150
150
}
151
151
defer committer .Close ()
152
152
153
- if err = deleteMilestoneLabel (ctx , milestone , label , doer ); err != nil {
153
+ if err = deleteMilestoneLabel (ctx , m , label , doer ); err != nil {
154
154
return err
155
155
}
156
156
157
157
return committer .Commit ()
158
158
}
159
159
160
160
// LoadLabels loads labels
161
- func (milestone * Milestone ) LoadLabels () error {
162
- return milestone .loadLabels (db .GetEngine (db .DefaultContext ))
161
+ func (m * Milestone ) LoadLabels () error {
162
+ return m .loadLabels (db .GetEngine (db .DefaultContext ))
163
163
}
164
164
165
- func (milestone * Milestone ) loadLabels (e db.Engine ) (err error ) {
166
- if milestone .Labels == nil {
167
- milestone .Labels , err = getLabelsByMilestoneID (e , milestone .ID )
165
+ func (m * Milestone ) loadLabels (e db.Engine ) (err error ) {
166
+ if m .Labels == nil {
167
+ m .Labels , err = getLabelsByMilestoneID (e , m .ID )
168
168
if err != nil {
169
- return fmt .Errorf ("getLabelsByMilestoneID [%d]: %v" , milestone .ID , err )
169
+ return fmt .Errorf ("getLabelsByMilestoneID [%d]: %v" , m .ID , err )
170
170
}
171
171
}
172
172
return nil
173
173
}
174
174
175
- func (milestone * Milestone ) hasLabel (e db.Engine , labelID int64 ) bool {
176
- return hasMilestoneLabel (e , milestone .ID , labelID )
175
+ func (m * Milestone ) hasLabel (e db.Engine , labelID int64 ) bool {
176
+ return hasMilestoneLabel (e , m .ID , labelID )
177
177
}
178
178
179
179
// HasLabel returns true if milestone has been labeled by given ID.
180
- func (milestone * Milestone ) HasLabel (labelID int64 ) bool {
181
- return milestone .hasLabel (db .GetEngine (db .DefaultContext ), labelID )
180
+ func (m * Milestone ) HasLabel (labelID int64 ) bool {
181
+ return m .hasLabel (db .GetEngine (db .DefaultContext ), labelID )
182
182
}
183
183
184
- func (milestone * Milestone ) addLabel (ctx context.Context , label * Label , doer * user_model.User ) error {
185
- return newMilestoneLabel (ctx , milestone , label , doer )
184
+ func (m * Milestone ) addLabel (ctx context.Context , label * Label , doer * user_model.User ) error {
185
+ return newMilestoneLabel (ctx , m , label , doer )
186
186
}
187
187
188
188
// AddLabels adds a list of new labels to the milestone.
189
- func (milestone * Milestone ) AddLabels (doer * user_model.User , labels []* Label ) error {
190
- return NewMilestoneLabels (milestone , labels , doer )
189
+ func (m * Milestone ) AddLabels (doer * user_model.User , labels []* Label ) error {
190
+ return NewMilestoneLabels (m , labels , doer )
191
191
}
192
192
193
- func (milestone * Milestone ) addLabels (ctx context.Context , e db.Engine , labels []* Label , doer * user_model.User ) error {
194
- return newMilestoneLabels (ctx , e , milestone , labels , doer )
193
+ func (m * Milestone ) addLabels (ctx context.Context , e db.Engine , labels []* Label , doer * user_model.User ) error {
194
+ return newMilestoneLabels (ctx , e , m , labels , doer )
195
195
}
196
196
197
- func (milestone * Milestone ) removeLabel (ctx context.Context , doer * user_model.User , label * Label ) error {
198
- return deleteMilestoneLabel (ctx , milestone , label , doer )
197
+ func (m * Milestone ) removeLabel (ctx context.Context , doer * user_model.User , label * Label ) error {
198
+ return deleteMilestoneLabel (ctx , m , label , doer )
199
199
}
200
200
201
- func (milestone * Milestone ) clearLabels (ctx context.Context , e db.Engine , doer * user_model.User ) (err error ) {
202
- if err = milestone .loadLabels (e ); err != nil {
201
+ func (m * Milestone ) clearLabels (ctx context.Context , e db.Engine , doer * user_model.User ) (err error ) {
202
+ if err = m .loadLabels (e ); err != nil {
203
203
return fmt .Errorf ("getLabels: %v" , err )
204
204
}
205
205
206
- for i := range milestone .Labels {
207
- if err = milestone .removeLabel (ctx , doer , milestone .Labels [i ]); err != nil {
206
+ for i := range m .Labels {
207
+ if err = m .removeLabel (ctx , doer , m .Labels [i ]); err != nil {
208
208
return fmt .Errorf ("removeLabel: %v" , err )
209
209
}
210
210
}
@@ -214,22 +214,22 @@ func (milestone *Milestone) clearLabels(ctx context.Context, e db.Engine, doer *
214
214
215
215
// ClearLabels removes all milestone labels as the given user.
216
216
// Triggers appropriate WebHooks, if any.
217
- func (milestone * Milestone ) ClearLabels (doer * user_model.User ) (err error ) {
217
+ func (m * Milestone ) ClearLabels (doer * user_model.User ) (err error ) {
218
218
ctx , committer , err := db .TxContext ()
219
219
if err != nil {
220
220
return err
221
221
}
222
222
defer committer .Close ()
223
223
224
- perm , err := access_model .GetUserRepoPermission (ctx , milestone .Repo , doer )
224
+ perm , err := access_model .GetUserRepoPermission (ctx , m .Repo , doer )
225
225
if err != nil {
226
226
return err
227
227
}
228
228
if ! perm .CanWriteIssuesOrPulls (true ) {
229
229
return ErrRepoLabelNotExist {}
230
230
}
231
231
232
- if err = milestone .clearLabels (ctx , db .GetEngine (ctx ), doer ); err != nil {
232
+ if err = m .clearLabels (ctx , db .GetEngine (ctx ), doer ); err != nil {
233
233
return err
234
234
}
235
235
@@ -242,37 +242,37 @@ func (milestone *Milestone) ClearLabels(doer *user_model.User) (err error) {
242
242
243
243
// ReplaceLabels removes all current labels and adds the given labels to the milestone.
244
244
// Triggers appropriate WebHooks, if any.
245
- func (milestone * Milestone ) ReplaceLabels (labels []* Label , doer * user_model.User ) (err error ) {
245
+ func (m * Milestone ) ReplaceLabels (labels []* Label , doer * user_model.User ) (err error ) {
246
246
ctx , committer , err := db .TxContext ()
247
247
if err != nil {
248
248
return err
249
249
}
250
250
defer committer .Close ()
251
251
252
- if err = milestone .loadLabels (db .GetEngine (ctx )); err != nil {
252
+ if err = m .loadLabels (db .GetEngine (ctx )); err != nil {
253
253
return err
254
254
}
255
255
256
256
sort .Sort (labelSorter (labels ))
257
- sort .Sort (labelSorter (milestone .Labels ))
257
+ sort .Sort (labelSorter (m .Labels ))
258
258
259
259
var toAdd , toRemove []* Label
260
260
261
261
addIndex , removeIndex := 0 , 0
262
- for addIndex < len (labels ) && removeIndex < len (milestone .Labels ) {
262
+ for addIndex < len (labels ) && removeIndex < len (m .Labels ) {
263
263
addLabel := labels [addIndex ]
264
- removeLabel := milestone .Labels [removeIndex ]
264
+ removeLabel := m .Labels [removeIndex ]
265
265
if addLabel .ID == removeLabel .ID {
266
266
// Silently drop invalid labels
267
- if removeLabel .RepoID != milestone .RepoID && removeLabel .OrgID != milestone .Repo .OwnerID {
267
+ if removeLabel .RepoID != m .RepoID && removeLabel .OrgID != m .Repo .OwnerID {
268
268
toRemove = append (toRemove , removeLabel )
269
269
}
270
270
271
271
addIndex ++
272
272
removeIndex ++
273
273
} else if addLabel .ID < removeLabel .ID {
274
274
// Only add if the label is valid
275
- if addLabel .RepoID == milestone .RepoID || addLabel .OrgID == milestone .Repo .OwnerID {
275
+ if addLabel .RepoID == m .RepoID || addLabel .OrgID == m .Repo .OwnerID {
276
276
toAdd = append (toAdd , addLabel )
277
277
}
278
278
addIndex ++
@@ -282,22 +282,22 @@ func (milestone *Milestone) ReplaceLabels(labels []*Label, doer *user_model.User
282
282
}
283
283
}
284
284
toAdd = append (toAdd , labels [addIndex :]... )
285
- toRemove = append (toRemove , milestone .Labels [removeIndex :]... )
285
+ toRemove = append (toRemove , m .Labels [removeIndex :]... )
286
286
287
287
if len (toAdd ) > 0 {
288
- if err = milestone .addLabels (ctx , db .GetEngine (ctx ), toAdd , doer ); err != nil {
288
+ if err = m .addLabels (ctx , db .GetEngine (ctx ), toAdd , doer ); err != nil {
289
289
return fmt .Errorf ("addLabels: %v" , err )
290
290
}
291
291
}
292
292
293
293
for _ , l := range toRemove {
294
- if err = milestone .removeLabel (ctx , doer , l ); err != nil {
294
+ if err = m .removeLabel (ctx , doer , l ); err != nil {
295
295
return fmt .Errorf ("removeLabel: %v" , err )
296
296
}
297
297
}
298
298
299
- milestone .Labels = nil
300
- if err = milestone .loadLabels (db .GetEngine (ctx )); err != nil {
299
+ m .Labels = nil
300
+ if err = m .loadLabels (db .GetEngine (ctx )); err != nil {
301
301
return err
302
302
}
303
303
0 commit comments