Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 19, 2020

  • Style search dropdown
  • Fix radio buttons and tweak checkboxes
  • Add styling for error form elements
  • Make borders brighter and focus more apparent
  • Adjust comment box border color to match

Fixes: #12491

image

Screen Shot 2020-10-19 at 22 14 15

image

image

image

May as well backport.

- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: go-gitea#12491
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #13214 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13214   +/-   ##
=======================================
  Coverage   42.01%   42.01%           
=======================================
  Files         683      683           
  Lines       75215    75215           
=======================================
+ Hits        31603    31605    +2     
+ Misses      38448    38446    -2     
  Partials     5164     5164           
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
models/repo_list.go 78.57% <0.00%> (-0.90%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
services/pull/patch.go 54.54% <0.00%> (+1.70%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.91%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67172b...293f28c. Read the comment docs.

@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 19, 2020
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI backport/v1.13 type/bug labels Oct 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 5626811 into go-gitea:master Oct 20, 2020
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Oct 20, 2020
- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: go-gitea#12491

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@techknowlogick
Copy link
Member

Backported in #13215

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Oct 20, 2020
techknowlogick added a commit that referenced this pull request Oct 20, 2020
- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: #12491

Co-authored-by: silverwind <[email protected]>
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 21, 2020
…ments-in-pull-request-label-style

* origin/master: (27 commits)
  [skip ci] Updated translations via Crowdin
  add more clarification to the issue-template.md (go-gitea#13235)
  go-version constraints ignore pre-releases (go-gitea#13234)
  [skip ci] Updated translations via Crowdin
  Update some JS dependencies (go-gitea#13222)
  Return the full rejection message and errors in flash errors (go-gitea#13221)
  Update heatmap fixtures to restore tests (go-gitea#13224)
  [skip ci] Updated translations via Crowdin
  Add review request api (go-gitea#11355)
  [skip ci] Updated translations via Crowdin
  When the git ref is unable to be found return broken pr (go-gitea#13218)
  Various arc-green fixes (go-gitea#13214)
  Show stale label for stale code comment which is marked as resolved (go-gitea#13213)
  Move install pages out of main macaron routes (go-gitea#13195)
  Use CSS Variables for fonts, remove postcss-loader (go-gitea#13204)
  [skip ci] Updated translations via Crowdin
  Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (go-gitea#13212)
  Fix size and clickable area on file table back link (go-gitea#13205)
  [skip ci] Updated translations via Crowdin
  Fix error in diff html rendering (go-gitea#13191)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants