Skip to content

Conversation

@xMasterX
Copy link

This fixes wrong size of input field

Before:
image

After:
image

@xMasterX xMasterX changed the title Fix input border size for filter button UI: Fix input field border size for filter button in green theme Aug 14, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12491 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12491      +/-   ##
==========================================
+ Coverage   43.74%   43.75%   +0.01%     
==========================================
  Files         631      631              
  Lines       69870    69870              
==========================================
+ Hits        30565    30572       +7     
+ Misses      34348    34345       -3     
+ Partials     4957     4953       -4     
Impacted Files Coverage Δ
models/unit.go 45.07% <0.00%> (-2.82%) ⬇️
services/pull/pull.go 42.72% <0.00%> (+0.69%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
services/pull/update.go 57.69% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb60a5d...a87a812. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 14, 2020
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Aug 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 14, 2020
@silverwind
Copy link
Member

silverwind commented Aug 14, 2020

Just playing around with this in the devtools, I think we still need to handle the focus style:

image

Generally I suggest not setting a border-width in the theme but let the width from the base theme take over. Themes can still set only border-color to change colors.

@techknowlogick techknowlogick added this to the 1.14.0 milestone Sep 5, 2020
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 19, 2020
- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: go-gitea#12491
techknowlogick added a commit that referenced this pull request Oct 20, 2020
- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: #12491

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Oct 20, 2020
- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: go-gitea#12491

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
techknowlogick added a commit that referenced this pull request Oct 20, 2020
- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: #12491

Co-authored-by: silverwind <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants