Skip to content

Add size limit for content of comment on action ui #12881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2020
Merged

Add size limit for content of comment on action ui #12881

merged 5 commits into from
Sep 18, 2020

Conversation

a1012112796
Copy link
Member

As tile, If the content of comment is to large, just show 200 words on action ui.
fix #12870

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #12881 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12881      +/-   ##
==========================================
- Coverage   43.10%   43.10%   -0.01%     
==========================================
  Files         656      656              
  Lines       72348    72353       +5     
==========================================
- Hits        31189    31186       -3     
- Misses      36108    36113       +5     
- Partials     5051     5054       +3
Impacted Files Coverage Δ
modules/notification/action/action.go 58.26% <50.00%> (-0.41%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (-0.82%) ⬇️
models/gpg_key.go 54.81% <0.00%> (-0.59%) ⬇️
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb5bbd...d98f240. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 17, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 17, 2020
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label Sep 17, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 17, 2020
@6543 6543 added the type/bug label Sep 17, 2020
lafriks
lafriks reviewed Sep 17, 2020
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2020
@lafriks lafriks merged commit 5995326 into go-gitea:master Sep 18, 2020
@lunny
Copy link
Member

lunny commented Sep 18, 2020

@a1012112796 Please send backport to v1.12

@a1012112796 a1012112796 deleted the action_comment_limit branch September 18, 2020 10:23
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Sep 18, 2020
@a1012112796 @mrsdizzie @lunny
Add size limit for content of comment on action ui (go-gitea#12881)
c050234 
Signed-off-by: a1012112796 <[email protected]>
Co-authored-by: mrsdizzie <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@a1012112796 a1012112796 mentioned this pull request Sep 18, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Sep 18, 2020
lunny added a commit that referenced this pull request Sep 18, 2020
@a1012112796 @mrsdizzie
@lunny @techknowlogick
Add size limit for content of comment on action ui (#12881) (#12890)
65aef7b 
Signed-off-by: a1012112796 <[email protected]>
Co-authored-by: mrsdizzie <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>

Co-authored-by: mrsdizzie <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Sep 18, 2020
@mrsdizzie
Fix panic when adding long comment
52623b6 
Previous PR go-gitea#12881 causes out of bounds panic by working on wrong string.
@mrsdizzie
Copy link
Member

This code and backport causes panic for large comments -- will send PR to fix

@mrsdizzie mrsdizzie mentioned this pull request Sep 18, 2020
Merged
techknowlogick pushed a commit that referenced this pull request Sep 18, 2020
@mrsdizzie
Fix panic when adding long comment (#12892)
25ddf77 
Previous PR #12881 causes out of bounds panic by working on wrong string.
mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Sep 18, 2020
@mrsdizzie
Fix panic when adding long comment (go-gitea#12892)
4a8468b 
Previous PR go-gitea#12881 causes out of bounds panic by working on wrong string.
@mrsdizzie mrsdizzie mentioned this pull request Sep 18, 2020
Merged
techknowlogick pushed a commit that referenced this pull request Sep 18, 2020
@mrsdizzie
Fix panic when adding long comment (#12892) (#12894)
23aae32 
Previous PR #12881 causes out of bounds panic by working on wrong string.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Activity feed is unreadable when a long text is submitted
8 participants
@a1012112796 @codecov-commenter @lunny @mrsdizzie @lafriks @6543 @techknowlogick @GiteaBot