Fix panic when adding long comment (#12892) (#12894)

mrsdizzie · web-flow · commit 23aae3274a89 · 2020-09-18T16:45:00.000-04:00
Previous PR #12881 causes out of bounds panic by working on wrong string.
diff --git a/modules/notification/action/action.go b/modules/notification/action/action.go
@@ -102,7 +102,7 @@ func (a *actionNotifier) NotifyCreateIssueComment(doer *models.User, repo *model
 	content := ""
 
 	if len(comment.Content) > 200 {
-		content = content[:strings.LastIndex(comment.Content[0:200], " ")] + "…"
+		content = comment.Content[:strings.LastIndex(comment.Content[0:200], " ")] + "…"
 	} else {
 		content = comment.Content
 	}

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ func (a actionNotifier) NotifyCreateIssueComment(doer models.User, repo *model`
`102`	`102`	`content := ""`
`103`	`103`
`104`	`104`	`if len(comment.Content) > 200 {`
`105`		`- content = content[:strings.LastIndex(comment.Content[0:200], " ")] + "…"`
	`105`	`+ content = comment.Content[:strings.LastIndex(comment.Content[0:200], " ")] + "…"`
`106`	`106`	`} else {`
`107`	`107`	`content = comment.Content`
`108`	`108`	`}`