Skip to content

Refresh codemirror on show pull comment tab (#11100) #11122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2020
Merged

Refresh codemirror on show pull comment tab (#11100) #11122

merged 1 commit into from
Apr 18, 2020

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 18, 2020 •
edited
Loading

Backport #11100

Fix #10975

Signed-off-by: Andrew Thornton [email protected]

@zeripath @jolheiser
@techknowlogick @guillep2k
Refresh codemirror on show pull comment tab (go-gitea#11100)
a8f0e0f 
Fix go-gitea#10975

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: guillep2k <[email protected]>
@zeripath zeripath added this to the 1.11.5 milestone Apr 18, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2020
@guillep2k
Copy link
Member

guillep2k commented Apr 18, 2020 •
edited
Loading

Is this a backport or an 1.11.5-only fix?
🤦‍♂️
Oh, don't mind me

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit d9875ff into go-gitea:release/v1.11 Apr 18, 2020
@zeripath zeripath deleted the backport-11100 branch April 18, 2020 19:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.11.5

Development

Successfully merging this pull request may close these issues.

4 participants

@zeripath @guillep2k @jolheiser @GiteaBot