Skip to content

Make pagination optional for API list notification endpoints #10714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Make pagination optional for API list notification endpoints #10714

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dac4fbc
make pagination optional for notificatins
6543 Apr 18, 2020
55408b3
Merge branch 'master' into api-optional-pagination
6543 Apr 20, 2020
7fae596
Merge branch 'master' into api-optional-pagination
lunny Apr 21, 2020
1017c6d
Merge branch 'master' into api-optional-pagination
zeripath Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion models/notification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ func (opts *FindNotificationOptions) ToCond() builder.Cond {

// ToSession will convert the given options to a xorm Session by using the conditions from ToCond and joining with issue table if required
func (opts *FindNotificationOptions) ToSession(e Engine) *xorm.Session {
return opts.setSessionPagination(e.Where(opts.ToCond()))
sess := e.Where(opts.ToCond())
if opts.Page != 0 {
sess = opts.setSessionPagination(sess)
}
return sess
}

func getNotifications(e Engine, options FindNotificationOptions) (nl NotificationList, err error) {
Expand Down