Skip to content

Make pagination optional for API list notification endpoints #10714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2020
Merged

Make pagination optional for API list notification endpoints #10714

merged 4 commits into from
Apr 21, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 11, 2020 •
edited
Loading

make pagination optional for list notification endpoints

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2020
@6543 6543 changed the title API optional pagination [WIP] API optional pagination Mar 11, 2020
@6543 6543 force-pushed the api-optional-pagination branch from 3ff427f to dac4fbc Compare April 18, 2020 00:51
@6543 6543 changed the title [WIP] API optional pagination [API] make pagination optional for list notification endpoints Apr 18, 2020
@6543
Copy link
Member Author

6543 commented Apr 18, 2020

@techknowlogick would be nice if you can add this to 1.12 :)

@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 18, 2020
@techknowlogick techknowlogick added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Apr 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #10714 into master will decrease coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10714      +/-   ##
==========================================
- Coverage   43.52%   43.52%   -0.01%     
==========================================
  Files         599      599              
  Lines       84824    84828       +4     
==========================================
+ Hits        36921    36922       +1     
- Misses      43355    43357       +2     
- Partials     4548     4549       +1
Impacted Files Coverage Δ
models/notification.go 62.62% <40.00%> (-0.30%) ⬇️
services/pull/check.go 53.65% <0.00%> (-1.83%) ⬇️
modules/notification/webhook/webhook.go 39.61% <0.00%> (-0.59%) ⬇️
models/error.go 32.09% <0.00%> (-0.54%) ⬇️
models/issue.go 51.48% <0.00%> (-0.47%) ⬇️
services/pull/pull.go 33.96% <0.00%> (ø)
modules/git/repo.go 50.62% <0.00%> (+0.83%) ⬆️
modules/log/event.go 65.64% <0.00%> (+1.02%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️
modules/indexer/stats/db.go 59.37% <0.00%> (+18.75%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12960b9...dac4fbc. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2020
@techknowlogick
Copy link
Member

I can't update branch on this PR, please mark as allow edits from maintainers :)

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 49f8b20 into go-gitea:master Apr 21, 2020
@zeripath zeripath deleted the api-optional-pagination branch April 21, 2020 21:21
@zeripath zeripath changed the title [API] make pagination optional for list notification endpoints Make pagination optional for API list notification endpoints Apr 21, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
make pagination optional for notifications (go-gitea#10714)
5ca6883
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-io @techknowlogick @zeripath @lunny @adelowo @GiteaBot