Skip to content

Update code dockerfile #8110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Update code dockerfile #8110

merged 1 commit into from
Feb 10, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Feb 9, 2022

Description

Related Issue(s)

Fixes #

How to test

  1. Select insiders in dashboard preferences
  2. Open workspace and check it starts successfully

Release Notes

NONE

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #8110 (1741cf9) into main (6e8e2a5) will decrease coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8110      +/-   ##
==========================================
- Coverage   11.98%   10.82%   -1.16%     
==========================================
  Files          20       18       -2     
  Lines        1193     1025     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1046      912     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.82% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8e2a5...1741cf9. Read the comment docs.

@iQQBot
Copy link
Contributor

iQQBot commented Feb 9, 2022

I still have the same question as before, the node versions of dependencies_builder and code_builder are not the same, is this really not a problem?

@jeanp413
Copy link
Member Author

jeanp413 commented Feb 9, 2022

@iQQBot it's fine as N-API is stable across versions https://nodejs.org/api/n-api.html#node-api-version-matrix, I also commented it in previous PR #8048 (comment)

@iQQBot
Copy link
Contributor

iQQBot commented Feb 9, 2022

Thank you for you clarified, maybe there is too many mail in my inbox I missed it

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and preview environment LGTM, maybe @iQQBot has some thoughts so I'll /hold for now.
image

Let's ship Insiders 1.65! :shipit:

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iQQBot
Copy link
Contributor

iQQBot commented Feb 10, 2022

/unhold

@roboquat roboquat merged commit fddc395 into main Feb 10, 2022
@roboquat roboquat deleted the jp/update-code-dockerfile branch February 10, 2022 02:07
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants