-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update code dockerfile #8110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code dockerfile #8110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8110 +/- ##
==========================================
- Coverage 11.98% 10.82% -1.16%
==========================================
Files 20 18 -2
Lines 1193 1025 -168
==========================================
- Hits 143 111 -32
+ Misses 1046 912 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I still have the same question as before, the node versions of dependencies_builder and code_builder are not the same, is this really not a problem? |
@iQQBot it's fine as N-API is stable across versions https://nodejs.org/api/n-api.html#node-api-version-matrix, I also commented it in previous PR #8048 (comment) |
Thank you for you clarified, maybe there is too many mail in my inbox I missed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and preview environment LGTM, maybe @iQQBot has some thoughts so I'll /hold for now.
Let's ship Insiders 1.65!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/unhold |
Description
Related Issue(s)
Fixes #
How to test
Release Notes