[code] Build code dependencies separately

[jeanp413]

Description

Build vscode native dependencies in a separate builder image openvscode-server-linux-build-agent:centos7-devtoolset8-x64
Related microsoft/vscode@b7712c0

Related Issue(s)

Fixes #

How to test

1. Select vscode insiders in dashboard/preferences
2. Open a workspace
3. Check everything works fine

Release Notes

NONE

[jeanp413]

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jp-build-code-dependencies.3

[codecov]

Codecov Report

Merging #8048 (736eed7) into main (9b17c59) will decrease coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8048      +/-   ##
==========================================
- Coverage   12.01%   10.86%   -1.16%     
==========================================
  Files          20       18       -2     
  Lines        1190     1022     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1043      909     -134     
+ Partials        4        2       -2     

Flag	Coverage Δ
components-gitpod-cli-app	10.86% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b17c59...736eed7. Read the comment docs.

[jeanp413]

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jp-build-code-dependencies.5

[iQQBot]

Suggested change

	&& git remote add origin https://github.com/gitpod-io/vscode \
	&& git remote add origin https://github.com/gitpod-io/openvscode-server \

[iQQBot]

dependencies_builder use node 16, will this have incompatibility issues?

[filiptronicek]

LGTM; starts up and all of the important bits (language smartness, browser previews, terminals are working fine as well) ✅

[roboquat]

LGTM label has been added.

Git tree hash: 72a3f2fc1ba6e59bdd0b0d9f304039d03908fa48

[roboquat]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: filiptronicek

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [filiptronicek]
• components/ide/OWNERS [filiptronicek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iQQBot]

associated issue is not need anymore?

[filiptronicek]

associated issue is not need anymore?

@iQQBot I'm not sure either, didn't want to skip your review comments 😕🙇‍♂️

Edit: looks like indeed it is no longer needed, the two review comments you left look like something non-blocking, correct? gitpod-io/vscode redirects to gitpod-io/openvscode-server and not sure about the possible compatibility issues, I'll leave that for @jeanp413 if he has any opinions on that.

[jeanp413]

yeah gitpod-io/vscode redirects to gitpod-io/openvscode-server but will be nice to update and regarding compatibility issues, it's fine as N-API is stable across versions https://nodejs.org/api/n-api.html#node-api-version-matrix