Skip to content

[public-api] Bind unimplemented WorkspacesServiceHandler using Connect #13595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Oct 4, 2022

Description

Adds an unimplemented handler for WorkspaceService using Connect

Related Issue(s)

How to test

Unit tests

➜ curl \
    --header "Content-Type: application/json" \
    --data '{"workspaceId": "123"}' \
    https://api.mp-public-9156e81389.preview.gitpod-dev.com/gitpod.v1.WorkspacesService/GetWorkspace

{"code":"unimplemented","message":"gitpod.v1.WorkspacesService.GetWorkspace is not implemented"}

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-public-api-bind-unimplemented-ws-handler.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added the size/M label Oct 4, 2022
@easyCZ easyCZ force-pushed the mp/public-api-codegen-buf branch 3 times, most recently from 68eb515 to 13bede9 Compare October 5, 2022 12:17
@easyCZ easyCZ force-pushed the mp/public-api-codegen-buf branch from 13bede9 to 52ae65c Compare October 6, 2022 11:48
Base automatically changed from mp/public-api-codegen-buf to main October 6, 2022 12:18
@roboquat roboquat added size/XXL and removed size/M labels Oct 6, 2022
@easyCZ easyCZ force-pushed the mp/public-api-bind-unimplemented-ws-handler branch from 2fdc1c8 to ef37a83 Compare October 6, 2022 12:38
@roboquat roboquat added size/M and removed size/XXL labels Oct 6, 2022
@easyCZ easyCZ force-pushed the mp/public-api-bind-unimplemented-ws-handler branch from ef37a83 to e292a36 Compare October 6, 2022 12:39
@easyCZ easyCZ force-pushed the mp/public-api-bind-unimplemented-ws-handler branch from e292a36 to 9674ae9 Compare October 6, 2022 12:41
@easyCZ easyCZ marked this pull request as ready for review October 6, 2022 13:49
@easyCZ easyCZ requested a review from a team October 6, 2022 13:49
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 6, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have parts of the WorkspaceService implemented right? So why does the handler here use an unimplemented handler for all these RPCs?

@roboquat roboquat merged commit e836dd4 into main Oct 6, 2022
@roboquat roboquat deleted the mp/public-api-bind-unimplemented-ws-handler branch October 6, 2022 14:06
@easyCZ
Copy link
Member Author

easyCZ commented Oct 6, 2022

Just to make it more incremental, wanted to demonstrate we can reach the service without actually changing the implementation at this stage :)

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants