-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[public-api] Generate Go and TS Connect protos with buf #13550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
406ea07
to
70888ca
Compare
Socket Security Report👍 No new dependency issues detected in pull request Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
91484e0
to
40afcbf
Compare
0943e14
to
de986f1
Compare
49a714e
to
6fa3d7c
Compare
1efb6ea
to
68eb515
Compare
68eb515
to
13bede9
Compare
@easyCZ I'm looking at generated code, and wonder how to use it? They seem to be specs of types and services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
code-generation works, but I'm not sure how to use generated code, there is also runtime deps to gitpod-protocol. Do we need it?
The dependency on |
@easyCZ it should go to dev deps then otherwise it going to be pulled on npm install by clients |
@akosyakov The way we use the client is here https://connect.build/docs/web/using-clients#promises It's also implemented in the original Connect prototype here |
nice! |
13bede9
to
52ae65c
Compare
Moved it to dev dependencies. |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, really looking forward to actually use connect-web
! 🙃
Yes, we can. It doesn't remove our ability to use gRPC but we can use buf to get slightly simpler clients with less "fluff" that gRPC has. It's made more user-friendly. |
Description
Extends buf configuration to generate Connect interfaces for Go and TS.
The generates TS is API compatible, just uses modern TS
Related Issue(s)
How to test
builds
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide