[public-api] Switch go codegen to buf #13579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/public-api-buf
branch
from
c335b01 to
10909f9
Compare
|
/werft run 👍 started the job as gitpod-build-mp-public-api-buf.4 |
3 tasks
andrew-farries
approved these changes
Oct 5, 2022
9 tasks
|
This appears to be blocking the merge pool for some reason even though it still has pending reviewers 😕 /hold |
csweichel
reviewed
Oct 5, 2022
easyCZ
force-pushed
the
mp/public-api-buf
branch
from
7605389 to
49a714e
Compare
easyCZ
force-pushed
the
mp/public-api-buf
branch
from
49a714e to
6fa3d7c
Compare
3 tasks
akosyakov
reviewed
Oct 5, 2022
|
The default libraries (TS, go, etc..) which use the code already embed the google RPC structs in their responses and in the protocol. We don't need to vendor them here (we're also not importing them into our protos). |
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses buf gen to generate go/grpc
This makes the configuration easier to read and removes the need to move files around.
This also removes the vendored dependency on google/rpc as it's not needed.
We can also the same for other packages.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide