Skip to content

Extract button component #16441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Feb 16, 2023 · 0 comments · Fixed by #16592
Closed

Extract button component #16441

gtsiolis opened this issue Feb 16, 2023 · 0 comments · Fixed by #16592
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 16, 2023

Problem to solve

There are around 60 instances of a button across the product, see <button> instances[1].

Currently, all buttons rely on the main button styles in index.css.

button {
@apply cursor-pointer px-4 py-2 my-auto bg-green-600 dark:bg-green-700 hover:bg-green-700 dark:hover:bg-green-600 text-gray-100 dark:text-green-100 text-sm font-medium rounded-md focus:outline-none focus:ring transition ease-in-out;
}

It would be great to have a button component to cover some of the sizes, states, categories, variants, content, etc. and also support light / dark theme.

The need for a button component has been discussed briefly before a couple of times:

See also relevant discussion in #16391 (comment). Cc @selfcontained

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant