Skip to content

[dashboard] Always start with options #16391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

[dashboard] Always start with options #16391

merged 1 commit into from
Feb 17, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Feb 14, 2023 •
edited
Loading

Description

Introduces a new CreateWorkspacePage on which the options are shown and can be changed.

The page is only activated for users who are in team-only mode already (change your email to [email protected] in user settings and reload the dashboard to activate it). There is also a feature flag that can enable it for other users (currently false everywhere).

This also moves /new to /projects/new so /new can be used for creating new workspaces.

Without the feature flag there will be no difference in starting workspaces, with one exception: /new works for everybody

Related Issue(s)

Fixes #16362

How to test

  1. Try starting workspaces in different ways. Should all work as usual.
  2. Change the user email to [email protected] and reload the browser to active org only attribution.
  3. All workspace creations now go to a new create workspace page.

Release Notes

New workspace creation page

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-start-with-options.4 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge changed the title [codeowners] Update registry-facade-api owner [dashboard] Always start with options Feb 14, 2023
@roboquat roboquat added size/XS and removed size/S labels Feb 15, 2023
@svenefftinge svenefftinge reopened this Feb 15, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-start-with-options.7 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge marked this pull request as ready for review February 16, 2023 10:51
@svenefftinge svenefftinge requested a review from a team February 16, 2023 10:51
@svenefftinge
Copy link
Member Author

/hold

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 16, 2023
@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM! 🌮 🌮

Left some comments below.

❓ What is [email protected]? I changed it in user settings, but didn't notice any difference—the /new page and flow remained the same. Should I see something different?

Approving to unblock merging but holding for someone from @gitpod-io/engineering-webapp to take a closer look at the code changes. 🏀

/hold

@svenefftinge
Copy link
Member Author

What is [email protected]?

It enables the team_only_attribution feature flag.
You need to reload the dashboard after that change.

@atduarte
Copy link
Contributor

atduarte commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Looking good! 🥳

Had a few issues though. I visited "/new" and at first it showed me a "Oh no something went wrong". Retrying worked. Same happened when I used the "gitpodl-link#repository-url" trick at first. And the second time the options did not appear. Am I doing something wrong?

Also noticed that the loading animation on the "Creating workspace" button had some issues.

selfcontained
selfcontained reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test it yet - preview env isn't loading for me atm - but wanted to share some comments on just the changes w/o waiting for testing it out.

@selfcontained
Copy link
Contributor

selfcontained commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-se-start-with-options.10
(with .werft/ from main)

@selfcontained
Copy link
Contributor

selfcontained commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-se-start-with-options.11
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-start-with-options.13
(with .werft/ from main)

@gtsiolis gtsiolis mentioned this pull request Feb 16, 2023
Closed
@svenefftinge
Copy link
Member Author

svenefftinge commented Feb 17, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-start-with-options.14
(with .werft/ from main)

@svenefftinge svenefftinge force-pushed the se/start-with-options branch 2 times, most recently from e085310 to fcb62cf Compare February 17, 2023 09:53
@svenefftinge
Copy link
Member Author

svenefftinge commented Feb 17, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-start-with-options.17
(with .werft/ from main)

@roboquat roboquat added size/XXL and removed size/XL labels Feb 17, 2023
@svenefftinge
Copy link
Member Author

/unhold

selfcontained
selfcontained approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you for the changes, I think we can do the rest as followups. From my testing, with the flag off, and if a user isn't migrated, they won't have this new experience yet, which is desired for now.

@roboquat roboquat merged commit 9e1cece into main Feb 17, 2023
@roboquat roboquat deleted the se/start-with-options branch February 17, 2023 15:25
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 21, 2023
@selfcontained selfcontained mentioned this pull request Feb 27, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

@selfcontained selfcontained selfcontained approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start workspaces using the currently selected org
5 participants
@svenefftinge @gtsiolis @atduarte @selfcontained @roboquat