Introduce linter to prevent aria-label misuse #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
force-pushed
the
kh-add_aria_label_misuse_linter
branch
from
d5eaa7e to
8787397
Compare
smockle
reviewed
Nov 30, 2021
smockle
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Ha, we just talked about this re: https://primer.style/css/components/tooltips#tooltip-direction. Nice work, @khiga8! 🚀
Co-authored-by: Clay Miller <[email protected]>
bolonio
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/accessibility/issues/430
What are you trying to accomplish?
This PR introduces a linter rule to prevent misuse of
aria-labelandaria-labelledby. For more information, see no-aria-label-misuse.mdNote
As noted in the rule docs, there are conflicting resources on what elements should support these naming attributes. For now, this rule will operate under a relatively simple heuristic aimed to minimize false positives and target the most common misuse of
aria-labelwe've seen, but there's definitely room for future improvements.