This repository was archived by the owner on Jun 21, 2023. It is now read-only.
I18n pull request restore with CrowdIn support #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
force-pushed
the
internationalization
branch
from
7adfbf5 to
0661a30
Compare
3 tasks
|
Merged #1871 into this branch, but it appears that the |
shana
suggested changes
Sep 6, 2018
crowdin.yml
Outdated
| - source: /src/**/Resources.en-US.resx | ||
| translation: /%original_path%/Resources.%locale%.resx | ||
| - source: /src/**/VSPackage.en-US.resx | ||
| translation: /%original_path%/VSPackage.%locale%.resx |
There was a problem hiding this comment.
I wouldn't do this one right now. This is information that's merged with the package for the marketplace and the extension list, not for the VS UI itself.
crowdin.yml
Outdated
| - source: /src/**/VSPackage.en-US.resx | ||
| translation: /%original_path%/VSPackage.%locale%.resx | ||
| - source: /src/**/OcticonPaths.en-US.resx | ||
| translation: /%original_path%/OcticonPaths.%locale%.resx |
There was a problem hiding this comment.
There is nothing to translate on this, these are icons in svg format.
shana
approved these changes
Sep 6, 2018
grokys
force-pushed
the
internationalization
branch
from
dfd1f70 to
9839f9c
Compare
|
@maikebing could take a look at this and tell me if I've got anything wrong? |
And move hard-coded UI strings to resources. Co-Authored-By: MysticBoy <[email protected]>
grokys
force-pushed
the
internationalization
branch
from
9839f9c to
d45f6b1
Compare
jcansdale
suggested changes
Sep 11, 2018
test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs
Show resolved
Hide resolved
test/GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs
Show resolved
Hide resolved
jcansdale
reviewed
Sep 11, 2018
| @@ -126,9 +146,13 @@ public async Task NoChangesInWorkingDirectory() | |||
| vsServices.DidNotReceiveWithAnyArgs().ShowMessageBoxInfo(null); | |||
| gitHubContextService.Received(1).TryOpenFile(repositoryDir, context); | |||
| } | |||
| [Test] | |||
Resolve resources that start with a "#" using ResolveResources.
|
Looking good! |
|
Where are the resources specified to be satellites? |
|
@StanleyGoldman the non- |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores parts of #1714 and adds initial integration with CrowdIn.
It is currently only providing translations in
zn-CHfor our.resxfiles. We're going to need a more scalable solution than duplicating the entirety of our.vsctfiles for every language so those files are going to be tackled in a separate PR.The neutral language
en-USresources are being stored directly in the assemblies themselves with satellite assemblies only being used for translations. This is because WPF does not work well with satellite assemblies for the neutral language.