This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix PR icon in Status Bar and GitHub Icon on Start Page #1871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1714 broke a few things that were causing this:
IncludeOutputGroupsInVSIX
/IncludeOutputGroupsInVSIXLocalOnly
properties fromGitHub.VisualStudio.csproj
. In the case ofGitHub.InlineReviews
andGitHub.StartPage
this prevented the packages loading which caused PR icon disappeared on the status bar #1863SatelliteDllsProjectOutputGroup
to the relevant references in order to get the satellite assemblies to be shipped along with the extensionThis wasn't a bug, but was unnecessary:
OcticonPaths.resx
doesn't need to be translated as it consists solely of XAML paths.Fixes #1863