Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fix PR icon in Status Bar and GitHub Icon on Start Page #1871

Merged
merged 3 commits into from
Sep 5, 2018

Conversation

grokys
Copy link
Contributor

@grokys grokys commented Aug 22, 2018

#1714 broke a few things that were causing this:

  • It removed the IncludeOutputGroupsInVSIX/IncludeOutputGroupsInVSIXLocalOnly properties from GitHub.VisualStudio.csproj. In the case of GitHub.InlineReviews and GitHub.StartPage this prevented the packages loading which caused PR icon disappeared on the status bar #1863
  • Once this was fixed, needed to add SatelliteDllsProjectOutputGroup to the relevant references in order to get the satellite assemblies to be shipped along with the extension

This wasn't a bug, but was unnecessary:

  • OcticonPaths.resx doesn't need to be translated as it consists solely of XAML paths.

Fixes #1863

grokys added 3 commits August 22, 2018 15:29
Allows the `GitHub.InlineReviews` and `GitHub.StartPage` packages to be loaded, but now XAML resources cant be found.
This property is needed where an assembly has satellite assemblies that need to be installed.
@shana
Copy link
Contributor

shana commented Aug 22, 2018

There are more changes in #1714 that seem unnecessary or not really clear:

@maikebing
Copy link
Contributor

  • GitHub.VisualStudio.en-US.vsct only have string , but GitHub.VisualStudio.vsct not any string , Other languages refer to this file !
  • [assembly: NeutralResourcesLanguage("en-US")] This sentence can fall back to English!
  • src/GitHub.VisualStudio/VSPackage.zh-Hans.resx Should use Chinese, but the language has not yet organized very well, so, for the time being is still English instead.

@maikebing
Copy link
Contributor

Sorry, I can understand English, but I can only rely on Google translation to express my ideas.

@grokys grokys changed the base branch from master to internationalization September 5, 2018 11:34
@grokys grokys merged commit 60a3a14 into internationalization Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants