Weekly Digest (13 October, 2019 - 20 October, 2019)

[weekly-digest]

Here's the Weekly Digest for gitgitgadget/git:

---

ISSUES

Last week 14 issues were created.
Of these, 0 issues have been closed and 14 issues are still open.

OPEN ISSUES

💚 #407 vreportf: Fix interleaving issues, remove 4096 limitation, by SyntevoAlex
💚 #406 Add a build option to skip linking all those built-ins to their dashed form, by dscho
💚 #405 config: add documentation to config.h, by HebaWaly
💚 #404 t7519-status-fsmonitor: improve comments, by wilbaker
💚 #403 Consider ways to help with git switch @{-<n>} where <n> is unknown, by dscho
💚 #402 Revive 'pcre2-chartables-leakfix', by dscho
💚 #401 Handle git_path() with lock files correctly in worktrees, by dscho
💚 #400 ci: update caskroom/cask/perforce to new location, by derrickstolee
💚 #399 Get rid of the PRIuMAX guard in git-compat-util.h, by dscho
💚 #398 Teach strbuf a new trick: STRBUF_INIT_CONST("default"), by dscho
💚 #397 diff-highlight: fix a whitespace nit, by normanr
💚 #396 git-gui: Improve Japanese translation, by kdnakt
💚 #395 rebase: drop get_replay_opts(), by agrn
💚 #394 merge: add a --autostash option, by agrn

LIKED ISSUE

👍 #394 merge: add a --autostash option, by agrn
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #397 diff-highlight: fix a whitespace nit, by normanr
It received 12 comments.

---

PULL REQUESTS

Last week, 17 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 17 pull requests were updated.
💛 #407 vreportf: Fix interleaving issues, remove 4096 limitation, by SyntevoAlex
💛 #405 config: add documentation to config.h, by HebaWaly
💛 #404 t7519-status-fsmonitor: improve comments, by wilbaker
💛 #402 Revive 'pcre2-chartables-leakfix', by dscho
💛 #401 Handle git_path() with lock files correctly in worktrees, by dscho
💛 #400 ci: update caskroom/cask/perforce to new location, by derrickstolee
💛 #397 diff-highlight: fix a whitespace nit, by normanr
💛 #396 git-gui: Improve Japanese translation, by kdnakt
💛 #390 Dir rename fixes, by newren
💛 #389 gitk: Preserve window dimensions on exit when not using ttk themes, by echuber2
💛 #388 sequencer: start running post-commit hook again, by phillipwood
💛 #382 builtin/blame.c: bit field constants into bit shift format, by harry-hov
💛 #372 fsmonitor: don't fill bitmap with entries to be removed, by wilbaker
💛 #367 doc: Add a note about ~/.zsh/_git file, by mbelsky
💛 #361 git-gui: respect core.hooksPath, falling back to .git/hooks, by dscho
💛 #337 multi-pack-index: add --no-progress, by wilbaker
💛 #316 New sparse-checkout builtin and "cone" mode, by derrickstolee

---

COMMITS

Last week there were 34 commits.
🛠️ Git 2.24-rc0 Signed-off-by: Junio C Hamano [email protected] by gitster
🛠️ Merge branch 'rs/remote-curl-use-argv-array' Code cleanup. * rs/remote-curl-use-argv-array: remote-curl: use argv_array in parse_push() by gitster
🛠️ Merge branch 'rs/column-use-utf8-strnwidth' Code cleanup. * rs/column-use-utf8-strnwidth: column: use utf8_strnwidth() to strip out ANSI color escapes by gitster
🛠️ Merge branch 'rs/http-push-simplify' Code cleanup. * rs/http-push-simplify: http-push: simplify deleting a list item by gitster
🛠️ Merge branch 'jj/stash-reset-only-toplevel' "git stash save" lost local changes to submodules, which has been corrected. * jj/stash-reset-only-toplevel: stash: avoid recursive hard reset on submodules by gitster
🛠️ Merge branch 'bw/format-patch-o-create-leading-dirs' "git format-patch -o " did an equivalent of "mkdir " not "mkdir -p ", which is being corrected. * bw/format-patch-o-create-leading-dirs: format-patch: create leading components of output directory by gitster
🛠️ Merge branch 'bb/compat-util-comment-fix' Code cleanup. * bb/compat-util-comment-fix: git-compat-util: fix documentation syntax by gitster
🛠️ Merge branch 'bb/utf8-wcwidth-cleanup' Code cleanup. * bb/utf8-wcwidth-cleanup: utf8: use ARRAY_SIZE() in git_wcwidth() by gitster
🛠️ Merge branch 'dl/allow-running-cocci-verbosely' Dev support update. * dl/allow-running-cocci-verbosely: Makefile: respect $(V) in %.cocci.patch target by gitster
🛠️ Merge branch 'dl/compat-cleanup' Code formatting micronit fix. * dl/compat-cleanup: pthread.h: manually align parameter lists by gitster
🛠️ Merge branch 'ta/t1308-typofix' Test fix. * ta/t1308-typofix: t1308-config-set: fix a test that has a typo by gitster
🛠️ Merge branch 'js/doc-stash-save' Doc clarification. * js/doc-stash-save: doc(stash): clarify the description of save by gitster
🛠️ Ninth batch Signed-off-by: Junio C Hamano [email protected] by gitster
🛠️ Merge branch 'jk/coc' Code-of-conduct document. * jk/coc: CODE_OF_CONDUCT: mention individual project-leader emails add a Code of Conduct document by gitster
🛠️ Merge branch 'js/trace2-fetch-push' Dev support. * js/trace2-fetch-push: transport: push codepath can take arbitrary repository push: add trace2 instrumentation fetch: add trace2 instrumentation by gitster
🛠️ Merge branch 'jt/push-avoid-lazy-fetch' Performance hack. * jt/push-avoid-lazy-fetch: send-pack: never fetch when checking exclusions by gitster
🛠️ Merge branch 'dl/format-patch-doc-test-cleanup' test cleanup. * dl/format-patch-doc-test-cleanup: t4014: treat rev-list output as the expected value by gitster
🛠️ Merge branch 'js/xdiffi-comment-updates' Comment update. * js/xdiffi-comment-updates: xdiffi: fix typos and touch up comments by gitster
🛠️ Merge branch 'dl/t0000-skip-test-test' test update. * dl/t0000-skip-test-test: t0000: cover GIT_SKIP_TESTS blindspots by gitster
🛠️ Merge branch 'tg/range-diff-output-update' "git range-diff" failed to handle mode-only change, which has been corrected. * tg/range-diff-output-update: range-diff: don't segfault with mode-only changes by gitster
🛠️ Merge branch 'gs/sq-quote-buf-pretty' Pretty-printed command line formatter (used in e.g. reporting the command being run by the tracing API) had a bug that lost an argument that is an empty string, which has been corrected. * gs/sq-quote-buf-pretty: sq_quote_buf_pretty: don't drop empty arguments by gitster
🛠️ Merge branch 'ew/hashmap' Code clean-up of the hashmap API, both users and implementation. * ew/hashmap: hashmap_entry: remove first member requirement from docs hashmap: remove type arg from hashmap_{get,put,remove}entry OFFSETOF_VAR macro to simplify hashmap iterators hashmap: introduce hashmap_free_entries hashmap: hashmap{put,remove} return hashmap_entry * hashmap: use *_entry APIs for iteration hashmap_cmp_fn takes hashmap_entry params hashmap_get{,_from_hash} return "struct hashmap_entry *" hashmap: use *_entry APIs to wrap container_of hashmap_get_next returns "struct hashmap_entry *" introduce container_of macro hashmap_put takes "struct hashmap_entry *" hashmap_remove takes "const struct hashmap_entry *" hashmap_get takes "const struct hashmap_entry *" hashmap_add takes "struct hashmap_entry *" hashmap_get_next takes "const struct hashmap_entry *" hashmap_entry_init takes "struct hashmap_entry *" packfile: use hashmap_entry in delta_base_cache_entry coccicheck: detect hashmap_entry.hash assignment diff: use hashmap_entry_init on moved_entry.ent by gitster
🛠️ Merge branch 'js/trace2-cap-max-output-files' The trace2 output, when sending them to files in a designated directory, can populate the directory with too many files; a mechanism is introduced to set the maximum number of files and discard further logs when the maximum is reached. * js/trace2-cap-max-output-files: trace2: write discard message to sentinel files trace2: discard new traces if target directory has too many files docs: clarify trace2 version invariants docs: mention trace2 target-dir mode in git-config by gitster
🛠️ Merge branch 'am/t0028-utf16-tests' Test fixes. * am/t0028-utf16-tests: t0028: add more tests t0028: fix test for UTF-16-LE-BOM by gitster
🛠️ Merge branch 'dl/octopus-graph-bug' "git log --graph" for an octopus merge is sometimes colored incorrectly, which is demonstrated and documented but not yet fixed. * dl/octopus-graph-bug: t4214: demonstrate octopus graph coloring failure t4214: explicitly list tags in log t4214: generate expect in their own test cases t4214: use test_merge test-lib: let test_merge() perform octopus merges by gitster
🛠️ Merge branch 'en/fast-imexport-nested-tags' Updates to fast-import/export. * en/fast-imexport-nested-tags: fast-export: handle nested tags t9350: add tests for tags of things other than a commit fast-export: allow user to request tags be marked with --mark-tags fast-export: add support for --import-marks-if-exists fast-import: add support for new 'alias' command fast-import: allow tags to be identified by mark labels fast-import: fix handling of deleted tags fast-export: fix exporting a tag and nothing else by gitster
🛠️ Merge branch 'js/azure-pipelines-msvc' CI updates. * js/azure-pipelines-msvc: ci: also build and test with MS Visual Studio on Azure Pipelines ci: really use shallow clones on Azure Pipelines tests: let --immediate and --write-junit-xml play well together test-tool run-command: learn to run (parts of) the testsuite vcxproj: include more generated files vcxproj: only copy git-remote-http.exe once it was built msvc: work around a bug in GetEnvironmentVariable() msvc: handle DEVELOPER=1 msvc: ignore some libraries when linking compat/win32/path-utils.h: add #include guards winansi: use FLEX_ARRAY to avoid compiler warning msvc: avoid using minus operator on unsigned types push: do not pretend to return int from die_push_simple() by gitster
🛠️ Merge branch 'gs/commit-graph-trace-with-cmd' Dev support. * gs/commit-graph-trace-with-cmd: commit-graph: emit trace2 cmd_mode for each sub-command by gitster
🛠️ Merge branch 'js/fetch-jobs' "git fetch --jobs=" allowed parallel jobs when fetching submodules, but this did not apply to "git fetch --multiple" that fetches from multiple remote repositories. It now does. * js/fetch-jobs: fetch: let --jobs= parallelize --multiple, too by gitster
🛠️ Merge branch 'en/merge-recursive-cleanup' The merge-recursive machiery is one of the most complex parts of the system that accumulated cruft over time. This large series cleans up the implementation quite a bit. * en/merge-recursive-cleanup: (26 commits) merge-recursive: fix the fix to the diff3 common ancestor label merge-recursive: fix the diff3 common ancestor label for virtual commits merge-recursive: alphabetize include list merge-recursive: add sanity checks for relevant merge_options merge-recursive: rename MERGE_RECURSIVE_* to MERGE_VARIANT_* merge-recursive: split internal fields into a separate struct merge-recursive: avoid losing output and leaking memory holding that output merge-recursive: comment and reorder the merge_options fields merge-recursive: consolidate unnecessary fields in merge_options merge-recursive: move some definitions around to clean up the header merge-recursive: rename merge_options argument to opt in header merge-recursive: rename 'mrtree' to 'result_tree', for clarity merge-recursive: use common name for ancestors/common/base_list merge-recursive: fix some overly long lines cache-tree: share code between functions writing an index as a tree merge-recursive: don't force external callers to do our logging merge-recursive: remove useless parameter in merge_trees() merge-recursive: exit early if index != head Ensure index matches head before invoking merge machinery, round N merge-recursive: remove another implicit dependency on the_repository ... by gitster
🛠️ remote-curl: use argv_array in parse_push() Use argv_array to build an array of strings instead of open-coding it. This simplifies the code a bit. We also need to make the specs parameter of push(), push_dav() and push_git() const to match the argv member of the argv_array. That's fine, as all three only actually read from the specs array anyway. Signed-off-by: René Scharfe [email protected] Signed-off-by: Junio C Hamano [email protected] by rscharfe
🛠️ column: use utf8_strnwidth() to strip out ANSI color escapes Make use of utf8_strnwidth()'s feature to skip ANSI escape sequences instead of open-coding it. This shortens the code and makes it more consistent. This changes the behavior, though: The old code skips all kinds of Control Sequence Introducer sequences, while utf8_strnwidth() only skips the Select Graphic Rendition kind, i.e. those ending with "m". They are used for specifying color and font attributes like boldness. The only other kind of escape sequence we print in Git is Erase in Line, ending with "K". That's not used for columnar output, so this difference actually doesn't matter here. Signed-off-by: René Scharfe [email protected] Signed-off-by: Junio C Hamano [email protected] by rscharfe
🛠️ http-push: simplify deleting a list item The first step for deleting an item from a linked list is to locate the item preceding it. Be more careful in release_request() and handle an empty list. This only has consequences for invalid delete requests (removing the same item twice, or deleting an item that was never added to the list), but simplifies the loop condition as well as the check after the loop. Once we found the item's predecessor in the list, update its next pointer to skip over the item, which removes it from the list. In other words: Make the item's successor the successor of its predecessor. (At this point entry->next == request and prev->next == lock, respectively.) This is a bit simpler and saves a pointer dereference. Signed-off-by: René Scharfe [email protected] Signed-off-by: Junio C Hamano [email protected] by rscharfe
🛠️ stash: avoid recursive hard reset on submodules git stash push does not recursively stash submodules, but if submodule.recurse is set, it may recursively reset --hard them. Having only the destructive action recurse is likely to be surprising behaviour, and unlikely to be desirable, so the easiest fix should be to ensure that the call to git reset --hard never recurses into submodules. This matches the behavior of check_changes_tracked_files, which ignores submodules. Signed-off-by: Jakob Jarmar [email protected] Signed-off-by: Junio C Hamano [email protected] by jarmar

---

CONTRIBUTORS

Last week there were 3 contributors.
👤 gitster
👤 rscharfe
👤 jarmar

---

STARGAZERS

Last week there was 1 stargazer.
⭐ altimumdelta
You are the star! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository gitgitgadget/git to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆