You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The builtin rebase stores its option to a struct rebase_options, but the sequencer wants a struct replay_opts. So, before starting an interactive rebase, the former must be converted to the latter. That’s what get_replay_opts() is all about. Instead of that, it could be cleaner to remove the redundancies between struct rebase_options and struct replay_opts, and then to get rid of get_replay_opts().
I already started some work on this, but as ra/rebase-i-more-options adds, well, more options to rebase -i, and thus is touching get_replay_opts(), I prefer to delay this a bit.
The text was updated successfully, but these errors were encountered:
agrn
added
the
leftoverbits
From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits
label
Oct 14, 2019
The builtin rebase stores its option to a
struct rebase_options
, but the sequencer wants astruct replay_opts
. So, before starting an interactive rebase, the former must be converted to the latter. That’s what get_replay_opts() is all about. Instead of that, it could be cleaner to remove the redundancies betweenstruct rebase_options
andstruct replay_opts
, and then to get rid of get_replay_opts().I already brought it up there: https://public-inbox.org/git/[email protected]/
I already started some work on this, but as
ra/rebase-i-more-options
adds, well, more options torebase -i
, and thus is touching get_replay_opts(), I prefer to delay this a bit.The text was updated successfully, but these errors were encountered: