Skip to content

rebase: drop get_replay_opts() #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agrn opened this issue Oct 13, 2019 · 0 comments
Open

rebase: drop get_replay_opts() #395

agrn opened this issue Oct 13, 2019 · 0 comments
Labels
leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits

Comments

@agrn
Copy link

agrn commented Oct 13, 2019

The builtin rebase stores its option to a struct rebase_options, but the sequencer wants a struct replay_opts. So, before starting an interactive rebase, the former must be converted to the latter. That’s what get_replay_opts() is all about. Instead of that, it could be cleaner to remove the redundancies between struct rebase_options and struct replay_opts, and then to get rid of get_replay_opts().

I already brought it up there: https://public-inbox.org/git/[email protected]/

I already started some work on this, but as ra/rebase-i-more-options adds, well, more options to rebase -i, and thus is touching get_replay_opts(), I prefer to delay this a bit.

@agrn agrn added the leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits
Projects
None yet
Development

No branches or pull requests

1 participant