[SYCL]fix ggml_sycl_mul_mat_id() to match the change of api #7436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
SYCL
mofosyne
added
the
Review Complexity : High
airMeng
reviewed
May 22, 2024
Contributor
AidanBeltonS
left a comment
AidanBeltonS
left a comment
There was a problem hiding this comment.
Some minor things which I think should be changed.
I have also tested this branch on an Arc A770 and A100 GPU and can confirm the MUL_MAT_ID implementation is working
airMeng
approved these changes
May 24, 2024
AidanBeltonS
approved these changes
May 24, 2024
Contributor
|
@arthw could you rebase this PR? I believe it will resolve the failing CI checks. |
Collaborator
yes, rebase it. |
Member
|
In It was added in #6505 as a workaround to avoid crashing SYCL with MoE models, but if mul_mat_id was fixed here, it should be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the ggml_sycl_mul_mat_id() which is impacted by the api parameters changed by #6505.
Now, only 1 mul_mat_id UT case is fault: type_a=iq4_nl. It's known issue.