Skip to content

Commit 32ba8d3

Browse files
committed
rm unused or duplicated code, rename as review comment
1 parent fbbd352 commit 32ba8d3

File tree

1 file changed

+15
-18
lines changed

1 file changed

+15
-18
lines changed

ggml-sycl.cpp

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16019,11 +16019,11 @@ __dpct_inline__ static void k_copy_dst_from_contiguous(
1601916019
static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1602016020
const ggml_tensor *src1,
1602116021
ggml_tensor *dst) try {
16022-
GGML_ASSERT(src0->backend != GGML_BACKEND_TYPE_GPU_SPLIT &&
16023-
"mul_mat_id does not support split buffers");
16022+
GGML_ASSERT(!ggml_backend_buffer_is_sycl_split(src0->buffer) && "mul_mat_id does not support split buffers");
16023+
1602416024
const ggml_tensor *ids = dst->src[2];
1602516025
GGML_TENSOR_BINARY_OP_LOCALS
16026-
GGML_ASSERT(!ggml_backend_buffer_is_sycl_split(src0->buffer) && "mul_mat_id does not support split buffers");
16026+
1602716027
const dpct::queue_ptr stream = g_syclStreams[g_main_device][0];
1602816028

1602916029
const int64_t n_as = ne02;
@@ -16142,13 +16142,13 @@ static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1614216142
sycl::range<3> block_dims(1, 1, std::min((unsigned int)ne10, 768u));
1614316143
sycl::range<3> grid_dims(1, n_ids, ids->ne[1]);
1614416144
stream->submit([&](sycl::handler &cgh) {
16145-
sycl::local_accessor<int, 0> src1_row_acc_ct1(cgh);
16145+
sycl::local_accessor<int, 0> src1_row_acc(cgh);
1614616146

16147-
char *__restrict src1_contiguous_get_ct1 =
16147+
char *__restrict src1_contiguous_get =
1614816148
src1_contiguous.get();
16149-
int *__restrict dev_cur_src1_row_get_ct2 =
16149+
int *__restrict dev_cur_src1_row_get =
1615016150
dev_cur_src1_row.get();
16151-
mmid_row_mapping *__restrict dev_row_mapping_get_ct3 =
16151+
mmid_row_mapping *__restrict dev_row_mapping_get =
1615216152
dev_row_mapping.get();
1615316153
size_t ids_nb_ct6 = ids->nb[1];
1615416154
size_t ids_nb_ct7 = ids->nb[0];
@@ -16157,11 +16157,11 @@ static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1615716157
sycl::nd_range<3>(grid_dims * block_dims, block_dims),
1615816158
[=](sycl::nd_item<3> item_ct1) {
1615916159
k_copy_src1_to_contiguous(
16160-
src1_original, src1_contiguous_get_ct1,
16161-
dev_cur_src1_row_get_ct2,
16162-
dev_row_mapping_get_ct3, ids_dev, i02,
16160+
src1_original, src1_contiguous_get,
16161+
dev_cur_src1_row_get,
16162+
dev_row_mapping_get, ids_dev, i02,
1616316163
ids_nb_ct6, ids_nb_ct7, ne11, ne10, nb11, nb12,
16164-
item_ct1, src1_row_acc_ct1);
16164+
item_ct1, src1_row_acc);
1616516165
});
1616616166
});
1616716167
}
@@ -16187,25 +16187,22 @@ static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1618716187
sycl::range<3> block_dims(1, 1, std::min((unsigned int)ne0, 768u));
1618816188
sycl::range<3> grid_dims(1, 1, num_src1_rows);
1618916189
stream->submit([&](sycl::handler &cgh) {
16190-
const char *__restrict dst_contiguous_get_ct1 =
16190+
const char *__restrict dst_contiguous_get =
1619116191
dst_contiguous.get();
16192-
const mmid_row_mapping *__restrict dev_row_mapping_get_ct2 =
16192+
const mmid_row_mapping *__restrict dev_row_mapping_get =
1619316193
dev_row_mapping.get();
1619416194

1619516195
cgh.parallel_for(
1619616196
sycl::nd_range<3>(grid_dims * block_dims, block_dims),
1619716197
[=](sycl::nd_item<3> item_ct1) {
1619816198
k_copy_dst_from_contiguous(dst_original,
16199-
dst_contiguous_get_ct1,
16200-
dev_row_mapping_get_ct2,
16199+
dst_contiguous_get,
16200+
dev_row_mapping_get,
1620116201
ne0, nb1, nb2, item_ct1);
1620216202
});
1620316203
});
1620416204
}
1620516205
}
16206-
if (dst->backend == GGML_BACKEND_TYPE_CPU) {
16207-
SYCL_CHECK(CHECK_TRY_ERROR(stream->wait()));
16208-
}
1620916206
}
1621016207
}
1621116208
catch (sycl::exception const &exc) {

0 commit comments

Comments
 (0)