Skip to content

fix(debug-image): Query by debug id and code id #95779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2025

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Jul 17, 2025

Align the frontend with #95651

Refs: getsentry/symbolicator#1731

@Dav1dde Dav1dde requested a review from a team as a code owner July 17, 2025 14:33
@Dav1dde Dav1dde requested review from a team July 17, 2025 14:33
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 17, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #95779   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files       10578    10578           
  Lines      610329   610329           
  Branches    23950    23950           
=======================================
  Hits       493684   493684           
  Misses     115937   115937           
  Partials      708      708           

cursor[bot]

This comment was marked as outdated.

Comment on lines -222 to +226
`/projects/${organization.slug}/${projSlug}/files/dsyms/?debug_id=${image?.debug_id}`,
`/projects/${organization.slug}/${projSlug}/files/dsyms/`,
{
query: {
debug_id: image?.debug_id,
code_id: image?.code_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for me to understand this, manually adding a query param to the URL here is equivalent to putting it in the query object?

Copy link
Member Author

@Dav1dde Dav1dde Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was weird to me, talked with @TkDodo and we figured out that it's not quite the same, in the case of null/undefined we do not get the strings null or undefined in the query, which is actually exactly what we want here (queries without code id should not search for an undefined id).

Otherwise it's the same.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@Dav1dde Dav1dde merged commit 36957ab into master Jul 17, 2025
47 checks passed
@Dav1dde Dav1dde deleted the dav1d/fe-code-id-debug-id branch July 17, 2025 15:23
cursor bot pushed a commit that referenced this pull request Jul 18, 2025
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants