-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(debug-image): Query by debug id and code id #95779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95779 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 10578 10578
Lines 610329 610329
Branches 23950 23950
=======================================
Hits 493684 493684
Misses 115937 115937
Partials 708 708 |
7bda596
to
3d7522f
Compare
`/projects/${organization.slug}/${projSlug}/files/dsyms/?debug_id=${image?.debug_id}`, | ||
`/projects/${organization.slug}/${projSlug}/files/dsyms/`, | ||
{ | ||
query: { | ||
debug_id: image?.debug_id, | ||
code_id: image?.code_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for me to understand this, manually adding a query param to the URL here is equivalent to putting it in the query
object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was weird to me, talked with @TkDodo and we figured out that it's not quite the same, in the case of null/undefined we do not get the strings null
or undefined
in the query, which is actually exactly what we want here (queries without code id should not search for an undefined
id).
Otherwise it's the same.
Align the frontend with #95651 Refs: getsentry/symbolicator#1731
Align the frontend with #95651 Refs: getsentry/symbolicator#1731
Align the frontend with #95651
Refs: getsentry/symbolicator#1731