Skip to content

Commit ab9f381

Browse files
Dav1ddeandrewshie-sentry
authored andcommitted
fix(debug-image): Query by debug id and code id (#95779)
Align the frontend with #95651 Refs: getsentry/symbolicator#1731
1 parent 6e858f3 commit ab9f381

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

static/app/components/events/interfaces/debugMeta/debugImageDetails/index.spec.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@ describe('Debug Meta - Image Details', function () {
1818
beforeEach(function () {
1919
MockApiClient.clearMockResponses();
2020
MockApiClient.addMockResponse({
21-
url: `/projects/${organization.slug}/${project.slug}/files/dsyms/?debug_id=${image.debug_id}`,
21+
url: `/projects/${organization.slug}/${project.slug}/files/dsyms/`,
2222
method: 'GET',
2323
body: [],
24+
match: [
25+
MockApiClient.matchQuery({debug_id: image?.debug_id, code_id: image?.code_id}),
26+
],
2427
});
2528

2629
MockApiClient.addMockResponse({

static/app/components/events/interfaces/debugMeta/debugImageDetails/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,11 @@ export function DebugImageDetails({
219219
refetch,
220220
} = useApiQuery<DebugFile[]>(
221221
[
222-
`/projects/${organization.slug}/${projSlug}/files/dsyms/?debug_id=${image?.debug_id}`,
222+
`/projects/${organization.slug}/${projSlug}/files/dsyms/`,
223223
{
224224
query: {
225+
debug_id: image?.debug_id,
226+
code_id: image?.code_id,
225227
// FIXME(swatinem): Ideally we should not filter here at all,
226228
// though Symbolicator does not currently report `bcsymbolmap` and `il2cpp`
227229
// candidates, and we would thus show bogus "unapplied" entries for those,

static/app/components/events/interfaces/debugMeta/index.spec.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,12 @@ describe('DebugMeta', function () {
2828
const event = EventFixture({entries: [eventEntryDebugMeta]});
2929
const image = eventEntryDebugMeta.data.images![0];
3030
const mockGetDebug = MockApiClient.addMockResponse({
31-
url: `/projects/${organization.slug}/${project.slug}/files/dsyms/?debug_id=${image?.debug_id}`,
31+
url: `/projects/${organization.slug}/${project.slug}/files/dsyms/`,
3232
method: 'GET',
3333
body: [],
34+
match: [
35+
MockApiClient.matchQuery({debug_id: image?.debug_id, code_id: image?.code_id}),
36+
],
3437
});
3538

3639
render(

0 commit comments

Comments
 (0)