build(actix): Update actix-web to v4. #316
Conversation
There was a problem hiding this comment.
Note: this raises the minimum supported Rust version from 1.45 to 1.46: actix/actix-web#1858
The Test MSRV job will need to be updated:
sentry-rust/.github/workflows/ci.yml
Line 102 in e8d0e1b
jan-auer
changed the title
sentry-actix/Cargo.toml
Outdated
| @@ -13,7 +13,7 @@ edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| sentry-core = { version = "0.22.0", path = "../sentry-core", default-features = false } | |||
There was a problem hiding this comment.
I need to add this for my project using actix-web v4 and this sentry-actix branch to compile for some reason:
| sentry-core = { version = "0.22.0", path = "../sentry-core", default-features = false } | |
| sentry-core = { version = "0.22.0", path = "../sentry-core", default-features = false, features=["client"] } |
There was a problem hiding this comment.
I also had to do this in my local fork
There was a problem hiding this comment.
Hmm, not sure about this as it seems to be working in my project and wasn't needed in previous versions.
There was a problem hiding this comment.
Ah, just managed to reproduce this. Honestly not sure why it wasn't happening before. It does appear it is now necessary though so I've updated the PR.
There was a problem hiding this comment.
I think this needs to update the tests to remove the &muts in call_service which now takes a shared reference.
|
Latest update should fix those lints, but happy to wait for the full release of v4 for this to be merged. |
|
@fourbytes Any update on this, I can't use it because I am getting this error: This error is similar to the one I found here: actix/actix-web#2633 |
|
superceded by #437 |
Updated sentry-actix to support actix-web v4 (currently still in beta).