Skip to content

sentry_actix 0.22 does not compile with actix-web 4.0.0-beta.6 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a1ph opened this issue Apr 27, 2021 · 2 comments · Fixed by #437
Closed

sentry_actix 0.22 does not compile with actix-web 4.0.0-beta.6 #327

a1ph opened this issue Apr 27, 2021 · 2 comments · Fixed by #437

Comments

@a1ph
Copy link

a1ph commented Apr 27, 2021

The problem is that tokio 1.x (which most people use these days) requires actix-rt 2.x, which requires actix-web 4.x, which does not seem to compile with sentry_actix (actix-web 3.x works fine). Any workaround? Thanks

267 |                 .wrap(sentry_actix::Sentry::new())
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Transform<actix_web::app_service::AppRouting, ServiceRequest>` is not implemented for `Sentry`
@Swatinem
Copy link
Member

A WIP PR is open here: #316 however I don’t really want to merge that quite yet until actix-web 4 is final.

@jplatte
Copy link

jplatte commented Jun 1, 2021

Here's an updated patch for 4.0-beta.5 compatibility: lumeohq@462511c

It's reporting all issues with an empty exception type and not much other useful data though, is that normal? (in particular I would expect the HTTP response code, which I don't get)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants